accessibility indicator in only-ubiquity

[Jim Paris]

I didn't experience this bug, but I was looking through the code and just noticed that it can't work as intended. This is from rev 5600:

--- bin/ubiquity-dm 2012-07-16 14:29:13 +0000
+++ bin/ubiquity-dm 2012-08-20 05:17:16 +0000
@@ -359,6 +359,7 @@
             # Accessibility infrastructure
             with open('/proc/cmdline', 'r') as fp:
                 if (accessibility or 'maybe-ubiquity' in fp.readline() or
+ 'only-ubiquity' in fp.readline() or
                     program_basename == 'oem-config-wrapper'):
                     launcher = '/usr/lib/at-spi2-core/at-spi-bus-launcher'
                     if os.path.exists(launcher):

You can't call fp.readline() twice like that... the second call will always return an empty string because /proc/cmdline only has one line.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubiquity - 2.17.0

---------------
ubiquity (2.17.0) trusty; urgency=low

  [ Aurélien Gâteau ]
  * Fix going back through skipped steps in kde_ui frontend.

  [ Dmitrijs Ledkovs ]
  * Switch "wireless" and "prepare" steps around (LP: #955232)
  * Don't read proc_cmdline twice (LP: #1213748)
  * Set wallpaper for 'feh' only, for others just assume gsettings schemes
    are correct.
  * Silence progress dots with invalid a11y (LP: #1154345)

  [ Colin Watson ]
  * Automatic update of included source packages: choose-mirror 2.50ubuntu1,
    debian-installer-utils 1.100ubuntu1, netcfg 1.111ubuntu1,
    partman-auto-lvm 51ubuntu1, partman-crypto 63ubuntu1, preseed
    1.62ubuntu1.
 -- Colin Watson <email address hidden> Tue, 29 Oct 2013 07:46:26 -0700