compact_compressed test is too slow in debug builds
Bug #1213102 reported by
Alexey Kopytov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
Medium
|
Alexey Kopytov | ||
| 2.1 |
Fix Released
|
Medium
|
Alexey Kopytov | ||
| 2.2 |
Fix Released
|
Medium
|
Alexey Kopytov | ||
Bug Description
The compact_compressed test is too slow in debug builds with most time spent in page_zip_
One way to fix this would be to disable UNIV_ZIP_DEBUG for debug XtraBackup builds. But that would remove validation for all tests.
Another way would be to disable compact_compressed for debug builds, which doesn't look good either.
A more acceptable solution seems to be to only call page_zip_validate() once per row (i.e. after inserting the row, but not before). Which would still provide good enough validation for all tests, but decrease compact_compressed execution time by ~50%.
Related branches
lp:~akopytov/percona-xtrabackup/bug1213102-2.1
- George Ormond Lorch III (community): Approve (g2)
-
Diff: 449 lines (+119/-140)14 files modifiedpatches/innodb51.patch (+13/-0)
patches/innodb55.patch (+13/-0)
patches/innodb56.patch (+13/-0)
patches/xtradb51.patch (+13/-0)
patches/xtradb55.patch (+13/-0)
test/inc/common.sh (+29/-0)
test/inc/ib_incremental_common.sh (+10/-36)
test/t/bug1182726.sh (+1/-9)
test/t/bug810269.sh (+1/-22)
test/t/compact_compressed.sh (+4/-3)
test/t/ib_slave_info.sh (+1/-9)
test/t/ib_stream_incremental.sh (+2/-19)
test/t/xb_export.sh (+1/-9)
test/t/xb_incremental_compressed.inc (+5/-33)
| tags: | added: low-hanging-fruit |
| summary: |
- compact_compressed test is too slow + compact_compressed test is too slow in debug builds |
| description: | updated |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/