possible race conditions in src/engine/loopingcontrol.cpp
Bug #1212952 reported by
Daniel Schürmann
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Low
|
Daniel Schürmann | ||
Bug Description
Since the slots are used from the controller thread and from the GUI thread, we may suffer race condition when we use both a the same time.
We should check and fix this.
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #1 |
| Changed in mixxx: | |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| tags: | added: engine |
Revision history for this message
| Daniel Schürmann (daschuer) wrote | #2 |
| Changed in mixxx: | |
| assignee: | nobody → Daniel Schürmann (daschuer) |
| milestone: | none → 2.1.0 |
| Changed in mixxx: | |
| status: | Confirmed → In Progress |
| Changed in mixxx: | |
| status: | In Progress → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #3 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
This happens all over the place unfortunately due to re-entrancy in Engine code. No non-engine thread code should be able to execute engine code. Everything needs to be separated by a request / response message passing system IMO. That's the only way we can finally get rid of locks and complicated race conditions in the engine.