iso8601 date parsing test failures (maybe with flask 0.10.1 )

Bug #1212851 reported by James Page
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Julien Danjou
ceilometer (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Running the ceilometer test suite on Ubuntu Saucy fails with errors of the following type:

======================================================================
FAIL: tests.api.v1.test_compute_duration_by_resource_scenarios.TestComputeDurationByResource.test_without_start_timestamp(sqlalchemy)
tags: worker-0
----------------------------------------------------------------------
Empty attachments:
  pythonlogging:''

traceback-2: {{{
Traceback (most recent call last):
  File "ceilometer/tests/base.py", line 78, in skip_if_not_implemented
    return func(*args, **kwargs)
  File "tests/api/v1/test_compute_duration_by_resource_scenarios.py", line 142, in test_without_start_timestamp
    self._assert_times_match(data['start_timestamp'], self.early1)
  File "tests/api/v1/test_compute_duration_by_resource_scenarios.py", line 87, in _assert_times_match
    actual = timeutils.parse_isotime(actual).replace(tzinfo=None)
  File "ceilometer/openstack/common/timeutils.py", line 52, in parse_isotime
    raise ValueError(e.message)
ValueError: Unable to parse date string u'Mon, 27 Aug 2012 07:00:00 GMT'
}}}

tests are using flask 0.10.1 (requirements.txt is patched to not reject this) which is potentially where the issue lies.

Julien Danjou (jdanjou)
Changed in ceilometer:
status: New → Triaged
assignee: nobody → Julien Danjou (jdanjou)
importance: Undecided → Medium
milestone: none → havana-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43478

Changed in ceilometer:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/43478
Committed: http://github.com/openstack/ceilometer/commit/706385d1e4c137510970c77900fa782ac3a61764
Submitter: Jenkins
Branch: master

commit 706385d1e4c137510970c77900fa782ac3a61764
Author: Julien Danjou <email address hidden>
Date: Fri Aug 23 14:44:30 2013 +0200

    api: update v1 for Flask >= 0.10

    Change-Id: I7e0e9a902ec57b6e5eb951d50a49629dd7cfdb7c
    Fixes-Bug: #1212851

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
James Page (james-page)
Changed in ceilometer (Ubuntu):
status: New → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.