Please entect ISCSI tries option into connector module

Bug #1212731 reported by OpenStack Infra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
Medium
Tom Fifield

Bug Description

https://review.openstack.org/41889
commit 3d591a50d489a185ca8d2b091e71e1960edf5c0d
Author: Nikolay Sobolevskiy <email address hidden>
Date: Thu Aug 15 19:23:27 2013 +0400

    Please entect ISCSI tries option into connector module

    The usage of this option occurred only in that module.
    Rename this options to num_volume_device_scan_tries,
    according to discussion on IRC.

    DocImpact
    Change-Id: Ib4a37237c2d95ca2dd6c05ce0a41f930b29ffd1c

Tags: cinder
Revision history for this message
Andreas Jaeger (jaegerandi) wrote :

Occurences in current manual (note: this is cinder only change):
./doc/src/docbkx/common/tables/nova-volumes.xml: <td>num_iscsi_scan_tries=3</td>
./doc/src/docbkx/common/tables/cinder-common.xml: <td>num_iscsi_scan_tries=3</td>
./tools/autogenerate-config-docs/flagmappings/cinder.flagmappings:num_iscsi_scan_tries common
./tools/autogenerate-config-docs/flagmappings/nova.flagmappings:num_iscsi_scan_tries volumes

Thus, should be fixed with next update with flagmappings.

Tom Fifield (fifieldt)
Changed in openstack-manuals:
status: New → Confirmed
milestone: none → havana
importance: Undecided → Medium
Revision history for this message
Anne Gentle (annegentle) wrote :

num_volume_device_scan_tries occurs in common/tables/cinder-storage.xml.
but num_iscsi_scan_tries still exists in nova-volume.xml. Should it?

Revision history for this message
Anne Gentle (annegentle) wrote :

Partial fix with https://review.openstack.org/#/c/47678/, but still wondering about nova-volume.

Revision history for this message
Tom Fifield (fifieldt) wrote :

confirmed with the code: num_iscsi_scan_tries is the deprecated name for num_volume_device_scan_tries

so it shound't be used as such, and in theory the generate tool should remove it...

Changed in openstack-manuals:
status: Confirmed → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-manuals (master)

Fix proposed to branch: master
Review: https://review.openstack.org/63286

Changed in openstack-manuals:
assignee: nobody → Tom Fifield (fifieldt)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/63286
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=6aa4346deb7df61140e64f0e1bbc9e60c49a3e8f
Submitter: Jenkins
Branch: master

commit 6aa4346deb7df61140e64f0e1bbc9e60c49a3e8f
Author: Tom Fifield <email address hidden>
Date: Fri Dec 20 11:16:00 2013 +0800

    Remove deprecated num_iscsi_scan_tries option

    This option has been replaced with num_volume_device_scan_tries

    Change-Id: I1949053eacdd77ac8b8d977cb9e7800ab885ee69
    Closes-Bug: 1212731

Changed in openstack-manuals:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-manuals 15.0.0

This issue was fixed in the openstack/openstack-manuals 15.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.