INNER joins nested under OUTER joins become OUTER

[Mike Rylander]

When enabling nullability selection in the report template interface, selection of an INNER (none-nullable) join type fails to produce an INNER join in the final SQL. This was actually intentional, as the behavior of a series of JOINs of varying flavors is confusing to some users, and an approximation of INNER-ness through IS NOT NULL clauses added to the WHERE produced results that, in some cases, seemed more correct to users. However, they're really not.

A branch addressing this is at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/clark-nested-inner-join

[Jason Boyer (jboyer)]

After much doc reading and head scratching, there's a signoff available at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/clark-nested-inner-join-signoff

[Mike Rylander (mrylander)]

Thanks for testing and sign-off, Jason. Merging...