Ratelimit plugin can send messages out of order
Bug #1211884 reported by
ChrisD
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
EnDroid |
Fix Released
|
Medium
|
Unassigned |
Bug Description
If ratelimit pluging starts limiting messages to a user it is possible that the user might end up received the messages from EnDroid in a different order to what they were sent in.
Once the ratelimit hits messages are added to a queue and a timer started to drain the queue.
If a messages is sent out of endroid before the timer fires but after a new token is made available the most recent message will be sent before the queued ones.
Fix is to have sc.accept to return the msg to send (or None if know message should be sent).
This msg will either be the message on the fron of the queue if there are messages on it, or the message being filtered if there are no messages on the queue.
Changed in endroid: | |
status: | Confirmed → Fix Committed |
Changed in endroid: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.