ScalingPolicy delete fails on user 404

[Steve Baker]

heat resource-show AutoScalingTest-1765383155 SmokeServerScaleUpPolicy
+------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Property | Value |
+------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| description | |
| links | http://192.168.1.70:8004/v1/80fe50a1630840588c628ff3efdbe5cc/stacks/AutoScalingTest-1765383155/84b279c0-325b-4a75-bffe-67f454cd778d/resources/SmokeServerScaleUpPolicy |
| | http://192.168.1.70:8004/v1/80fe50a1630840588c628ff3efdbe5cc/stacks/AutoScalingTest-1765383155/84b279c0-325b-4a75-bffe-67f454cd778d |
| logical_resource_id | SmokeServerScaleUpPolicy |
| physical_resource_id | 80e22ae734bb4396a350643f64115939 |
| required_by | MEMAlarmHigh |
| resource_status | DELETE_FAILED |
| resource_status_reason | NotFound: Could not find user, 80e22ae734bb4396a350643f64115939. (HTTP 404) |
| resource_type | AWS::AutoScaling::ScalingPolicy |
| updated_time | 2013-08-13T04:27:23Z |
+------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

[Steve Baker (steve-stevebaker)]

2013-08-14 11:05:44.646 ERROR heat.engine.resource [-] Delete ScalingPolicy "SmokeServerScaleDownPolicy"
2013-08-14 11:05:44.646 TRACE heat.engine.resource Traceback (most recent call last):
2013-08-14 11:05:44.646 TRACE heat.engine.resource File "/home/steveb/dev/localstack/heat/heat/engine/resource.py", line 530, in delete
2013-08-14 11:05:44.646 TRACE heat.engine.resource self.handle_delete()
2013-08-14 11:05:44.646 TRACE heat.engine.resource File "/home/steveb/dev/localstack/heat/heat/engine/signal_responder.py", line 54, in handle_delete
2013-08-14 11:05:44.646 TRACE heat.engine.resource self.keystone().delete_stack_user(self.resource_id)
2013-08-14 11:05:44.646 TRACE heat.engine.resource File "/home/steveb/dev/localstack/heat/heat/common/heat_keystoneclient.py", line 97, in delete_stack_user
2013-08-14 11:05:44.646 TRACE heat.engine.resource user = self.client.users.get(user_id)
2013-08-14 11:05:44.646 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/keystoneclient/v2_0/users.py", line 39, in get
2013-08-14 11:05:44.646 TRACE heat.engine.resource return self._get("/users/%s" % base.getid(user), "user")
2013-08-14 11:05:44.646 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/keystoneclient/base.py", line 81, in _get
2013-08-14 11:05:44.646 TRACE heat.engine.resource resp, body = self.api.get(url)
2013-08-14 11:05:44.646 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/keystoneclient/client.py", line 413, in get
2013-08-14 11:05:44.646 TRACE heat.engine.resource return self._cs_request(url, 'GET', **kwargs)
2013-08-14 11:05:44.646 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/keystoneclient/client.py", line 409, in _cs_request
2013-08-14 11:05:44.646 TRACE heat.engine.resource **kwargs)
2013-08-14 11:05:44.646 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/keystoneclient/client.py", line 382, in request
2013-08-14 11:05:44.646 TRACE heat.engine.resource raise exceptions.from_response(resp, body or resp.text)
2013-08-14 11:05:44.646 TRACE heat.engine.resource NotFound: Could not find user, c45e2590eb024b98a958b67e0803733a. (HTTP 404)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/41810

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/41810
Committed: http://github.com/openstack/heat/commit/bd37a3bee6f8bd3996aa1e017adb01546df385a6
Submitter: Jenkins
Branch: master

commit bd37a3bee6f8bd3996aa1e017adb01546df385a6
Author: Steve Baker <email address hidden>
Date: Wed Aug 14 11:15:38 2013 +1200

    Tolerate missing user on signal responder delete

    SignalResponder delete fails if the created user
    has already been deleted.

    This change catches the 404 as for the User resource.

    Change-Id: I55034469d10f2742296f0415fe26272d3683530d
    Closes-bug: #1211633