tests for Nova notifier fail because of nonexistent method

Bug #1211532 reported by Terri Yu
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Critical
Julien Danjou

Bug Description

When I run the Ceilometer unit tests, the tests for Nova notifier fail.

The relevant traceback from running the Ceilometer unit tests:

Traceback (most recent call last):
  File "/opt/stack/ceilometer/.tox/py27/local/lib/python2.7/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "/opt/stack/ceilometer/nova_tests/test_notifier.py", line 153, in setUp
    notifier_api.add_driver(self)
AttributeError: 'module' object has no attribute 'add_driver'

The reason for the failures is that the function add_driver() no longer exists in nova/openstack/common/notifier/api.py

This commit to the Nova repository deleted add_driver(): https://github.com/openstack/nova/commit/7b92cc75bb940be2c6b0c4b75abc8358941a4a6d

Revision history for this message
Terri Yu (terriyu) wrote :
description: updated
Julien Danjou (jdanjou)
Changed in ceilometer:
status: New → Confirmed
importance: Undecided → Critical
Changed in ceilometer:
assignee: nobody → Chmouel Boudjnah (chmouel)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/41628

Changed in ceilometer:
assignee: Chmouel Boudjnah (chmouel) → Julien Danjou (jdanjou)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/41628
Committed: http://github.com/openstack/ceilometer/commit/486f723f43ace9342532397c75b75efe0e913a2c
Submitter: Jenkins
Branch: master

commit 486f723f43ace9342532397c75b75efe0e913a2c
Author: Julien Danjou <email address hidden>
Date: Tue Aug 13 11:15:03 2013 +0200

    Fix nova test_notifier wrt new notifier API

    The Oslo notifier api lost add_driver(), and nova copy of that code has
    been updated recently, so that broke Ceilometer testing of that piece.
    Fix it by using another mechanism to test.

    Change-Id: I0169fcc9955501d490dfcdd7742205ea5c9ba15b
    Closes-Bug: #1211532

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
gordon chung (chungg) wrote :

wow. good catch Terri

Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.