Setting to disable payment by patron credit

[Bill Erickson]

I have two goals:

1. Disallow patron_credit payments in the payment API
2. Hide all of the patron credit payment actions in the staff client patron payment interface.

Note that #2 is partially implemented via existing "hide_patron_credit" CSS class. This class was added long ago to allow for local CSS to hide the patron credit actions. My strategy will be to hide any elements in the staff client billing UI which have this class when the org setting is activated. No local CSS required.

[Bill Erickson (berick)]

To further clarify #2, the "convert change to patron credit" action and the "Patron Credit" Payment Type (in the drop down) are what will be hidden.

[Bill Erickson (berick)]

Code pushed to http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1211473-disable-patron-credit

[Chris Sharp (chrissharp123)]

tested and signed off:

working/user/csharp/lp1211473-disable-patron-credit

[Dan Wells (dbw2)]

Ah, darn, I picked from the wrong branch and missed your signoff, Chris. Sorry about that! Rest assured that I was reviewing with your signoff in mind, and it was a positive factor in getting this in.

So, this is committed to master, but I have two questions. First, it looked like the newline in the event description made it into the alert, and affected the display. This was generally surprising to me. Do we need to be mindful when adding events to ils_events.xml that newlines are not just file formatting, but also message formatting? Or should event descriptions be stripped of newlines by the process reading from that xml file?

Second, I noticed that the 'Credit Available' portion of the bill display was still there even when patron credits were disabled for my current workstation (my patron had a positive credit). Of course, I couldn't actually apply it in any way, so we are good there. Should we hide that display as well? I can see arguments either way, so just soliciting more opinions. Or should this never happen under normal use?

Thanks, Bill, Chris, and Kathy (who gave a +1 via IRC)!

[Bill Erickson (berick)]

See also #1238015