[sdk]Switch theme button in UITK component gallery

Bug #1211382 reported by Jouni Helminen
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
Medium
Unassigned
Ubuntu UX
Fix Released
Undecided
Jouni Helminen
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned
Vivid
New
Undecided
Unassigned

Bug Description

We have been doing a design review of the toolkit app and would like to add a toolbar to the components.

In the toolbar we would want:

an icon for "Switch theme" to switch between light/dark/gradient themes. This will help us review the designs of components using the different themes. Matthieu is adding a new switch icon to the icon theme, it will be called switch.svg. Should land within a day or two

Related branches

Revision history for this message
Tim Peeters (tpeeters) wrote :

I don't understand 1). If you have a PageStack, there will automatically be a back button in the toolbar to go back one step in the stack. Going back to the "mainview" (without pages on the stack?) does not make sense because that would be empty. You need a Page.

For 2) I assume you are referring to the UITK gallery app?

Changed in ubuntu-ui-toolkit:
status: New → Incomplete
Revision history for this message
Jouni Helminen (jounihelminen) wrote :

Yes these bugs are relating to the UITK gallery app.

Currently there is no way to get back in the page stack to the list of components. Also there is no way to switch between the themes (dark/light/gradient) in the UITK gallery app - we need this so we can review the implementation of components matches designs

Changed in ubuntu-ui-toolkit:
importance: Undecided → High
Changed in ubuntu-ux:
assignee: nobody → Jouni Helminen (jounihelminen)
Changed in ubuntu-ui-toolkit:
assignee: Florian Boucault (fboucault) → Zsombor Egri (zsombi)
Revision history for this message
Zsombor Egri (zsombi) wrote :

The back button has been added through a separate bug fix, so the only need is to provide possibility to switch the theme.

Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
assignee: Zsombor Egri (zsombi) → Tim Peeters (tpeeters)
Tim Peeters (tpeeters)
summary: - Toolbar for components, with "Back" and "Switch theme" icons
+ Switch theme button in UITK component gallery
tags: added: theme uitk-gallery
Changed in ubuntu-ui-toolkit:
importance: High → Medium
assignee: Tim Peeters (tpeeters) → nobody
description: updated
Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit:
status: Incomplete → Confirmed
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Re: Switch theme button in UITK component gallery

Fix committed into lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: Confirmed → Fix Committed
Changed in ubuntu-ux:
status: New → Fix Committed
summary: - Switch theme button in UITK component gallery
+ [sdk]Switch theme button in UITK component gallery
Changed in ubuntu-ux:
status: Fix Committed → Fix Released
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.