Can't create folders into the bookmarks

[Sascha Morr]

When i try to create a new folder into the bookmarks and choose the parent folder, the dialog for creating the folder close itself.

Using Midori 0.5.4 on elementary OS Luna

[Sascha Morr (saschamorr)]

The same for creating bookmarks itself.

[André Auzi (aauzi)]

I've tried to investigate this issue.

I believe it's due to a confict, with Granite, between a grab done by the PopOver and the one done by the TreeMenu popup that's embedded within the ComboBox.

When the ComboBox is clicked, the popup TreeMenu is built and grabs the pointer.

Unfortunately, the PopOver hides itself when it loses the grab (on "grab-broken-event")

As a result, the PopOver is hidden before the ComboBox popup opening.

I'm not very familiar with Granite but from what I've understood this seems to be part of the way the PopOver detects loose of focus and automatically closes the PopOver on this event.

FWIMI: I could restore a functionnal behavior by a patch in Granite, in lib/Widgets/PopOver.vala

        size_allocate.connect(on_size_allocate);

- // if for example a DnD action from within the popover, our drag is broken
- // In this case, we just simply hide. Releasing the grab would make the DnD stop
- grab_broken_event.connect (() => {
- base.hide ();
-
- return false;
- });
  // once the DnD action ended, we'll have a blocked window, unless we remove the grab manually again
  grab_notify.connect ((was_grabbed) => {
   if (!was_shown || !was_grabbed)
    return;

   var pointer = Gdk.Display.get_default ().get_device_manager ().get_client_pointer ();
   Gtk.device_grab_remove (this, pointer);
   pointer.ungrab (Gdk.CURRENT_TIME);
  });

The simple removal of the grab-broken-event handler let the ComboBox work fine.

A side effect I could observe is that the PopOver does not hide itself anymore it you click in another window, after one used the ComboBox.

[Richard (merryidleness)]

This seems to still be an issue - after creating a bookmark folder and attempting to bookmark a site into it, midori freezes. When started from the console, output is:

(midori4:4781): Gtk-CRITICAL **: gtk_widget_get_toplevel: assertion 'GTK_IS_WIDGET (widget)' failed

(midori4:4781): GLib-GObject-CRITICAL **: g_object_ref: assertion 'G_IS_OBJECT (object)' failed

about:version below:

Command line midori
Midori 0.5.8 ((null)) Midori
GTK+ 3.12.2 (3.12.2) Glib 2.40.0 (2.40.0)
WebKitGTK+ 2.4.3 (2.4.3) libSoup 2.44.2
cairo 1.13.1 (1.13.1) libnotify 0.7.6
gcr No granite 0.3.0
Platform X11; Linux x86_64
Identification Mozilla/5.0 (X11; Linux) AppleWebKit/538.15 (KHTML, like Gecko) Chrome/18.0.1025.133 Safari/538.15 Midori/0.5
Video Formats H264 [x] Ogg Theora [x] WebM [x]