mkruntime.sh script is invalid sh

[Anders Kaseorg]

The mkruntime.sh script has some bashisms that need to be removed:

--- nspluginwrapper-0.9.91.4/utils/mkruntime.sh 2007-03-04 10:01:22.000000000 -0500
+++ nspluginwrapper-0.9.91.4/utils/mkruntime.sh 2007-06-02 21:08:13.000000000 -0400
@@ -12,15 +12,15 @@
 # - Check acroread5, something is missing while loading a PDF
 # - Enough for Flash Player & PluginSDK npsimple.so

-function error() {
+error() {
        echo ${1+"$@"} > /dev/stderr
 }

-function status() {
+status() {
        echo ${1+"$@"} > /dev/stderr
 }

-function run() {
+run() {
        status " " ${1+"$@"}
        ${1+"$@"}
 }

[Alexander Sack (asac)]

I guess its still the case, right?

[Anders Kaseorg (andersk)]

Yes…though looking at it again, the script may not be used at all on anything but Mandriva, so we probably don’t care. I only noticed because it generates a lintian error.

[Alexander Sack (asac)]

are we shipping mkruntime.sh in any binary package? Otherwise, this can be closed as Invalid.

Thanks,

  - Alexander

[Anders Kaseorg (andersk)]

Yes, it gets installed into /usr/lib/nspluginwrapper/noarch/mkruntime. (Otherwise it would not have generated a lintian error.)

[Alexander Sack (asac)]

lets move ahead.

[Alexander Sack (asac)]

debdiff appreciated.

[John Vivirito (gnomefreak)]

heres the debdiff

[John Vivirito (gnomefreak)]

heres the correct one

[John Vivirito (gnomefreak)]

Marked as fix committed as it should be uploaded shortly. Thank you for the diff anders

[Alexander Sack (asac)]

sponsored.

[John Vivirito (gnomefreak)]

It is in repos now.