"Edit Rules" in Security Group tab should be a better name

[Tanja Roth]

I observed something in the "Access & Security" category on the "Project" tab which seems peculiar to me (Grizzly release):

On the "Security Groups" tab, click "Edit Rules". Instead of being taken to a dialog where to _edit_ the rules, this takes you to the "Edit Security Groups" screen which lists the rules that are available for the chosen security group.
Here, it is also impossible to _edit_ the existing rules, instead you can only click "Add Rule" or "Delete Rules".

IIRC, in the Essex release, it was possible to edit existing rules directly. Now it takes the user up to 3 additional clicks to change a rule.

[Victoria Martinez de la Cruz (vkmc)]

I could reproduce this in Grizzly and in Havana too.

AFAIK the behaviour is the same in Essex - that is, you only can add or remove rules -, but that is because Nova API doesn't provide other way to edit security groups.

The only difference with Essex and current releases is that a modal is opened rather than a redirection to the Edit Security Groups page.

[Akihiro Motoki (amotoki)]

Actually both Nova and Neutron do not support the feature editing security group rules at now.
This is the reason we don't support editing existing rules directly, and the current implementation looks good to me.

About the title of the button, I agree "Edit Rules" is a bit confusing.
I prefer to "Manage Rules".

[Akihiro Motoki (amotoki)]

@Tanja,

Let me clarify what is the problem you think to move the bug forward.

Do you want to support editing existing rules? Are you saying the title of the button "Edit Rules" is a bit confusing and it is better to be renamed?

If the former, the bug is invalid until Nova or Neutron support secgroup rule editing.
If the latter, this can be a valid bug of Horizon (Low or Wish List priority).

Thanks

[Tanja Roth (taroth)]

My main concern was that the button title does not fit very well - something like "Manage Roles" would fit better, IMHO.

[Harikrishna (harikrishna-mallavolu)]

Akhilo Motoki - Are you still working on this bug??

[Julie Pichon (jpichon)]

Unassigning due to inactivity.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80399

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/80399
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8b84361d590bf2bb5191a71932033a8a115a7abc
Submitter: Jenkins
Branch: master

commit 8b84361d590bf2bb5191a71932033a8a115a7abc
Author: <email address hidden> <email address hidden>
Date: Thu Mar 13 15:57:56 2014 -0400

    Changed the label from Edit Rules to Manage Rules

    In the Access & Security' category under Project tab,
    for each security group, there is an option to edit
    the rules. Clicking this button, lists all the rules
    for a given security group and from there we can
    add/delete rules. Since there is no support for security
    group rule editing provided by Nova/Neutron, in this fix
    the label of the 'Edit Rules' button was changed to
    'Manage Rules' instead.

    Closes-Bug: 1210513

    Change-Id: I644c95b2f0147f5f59b543fd1eb9748ee4eb7e19