"Edit Rules" in Security Group tab should be a better name

Bug #1210513 reported by Tanja Roth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
mariam john

Bug Description

I observed something in the "Access & Security" category on the "Project" tab which seems peculiar to me (Grizzly release):

On the "Security Groups" tab, click "Edit Rules". Instead of being taken to a dialog where to _edit_ the rules, this takes you to the "Edit Security Groups" screen which lists the rules that are available for the chosen security group.
Here, it is also impossible to _edit_ the existing rules, instead you can only click "Add Rule" or "Delete Rules".

IIRC, in the Essex release, it was possible to edit existing rules directly. Now it takes the user up to 3 additional clicks to change a rule.

Revision history for this message
Victoria Martinez de la Cruz (vkmc) wrote :

I could reproduce this in Grizzly and in Havana too.

AFAIK the behaviour is the same in Essex - that is, you only can add or remove rules -, but that is because Nova API doesn't provide other way to edit security groups.

The only difference with Essex and current releases is that a modal is opened rather than a redirection to the Edit Security Groups page.

Akihiro Motoki (amotoki)
Changed in horizon:
status: New → Confirmed
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Actually both Nova and Neutron do not support the feature editing security group rules at now.
This is the reason we don't support editing existing rules directly, and the current implementation looks good to me.

About the title of the button, I agree "Edit Rules" is a bit confusing.
I prefer to "Manage Rules".

Changed in horizon:
status: Confirmed → New
Revision history for this message
Akihiro Motoki (amotoki) wrote :

@Tanja,

Let me clarify what is the problem you think to move the bug forward.

Do you want to support editing existing rules? Are you saying the title of the button "Edit Rules" is a bit confusing and it is better to be renamed?

If the former, the bug is invalid until Nova or Neutron support secgroup rule editing.
If the latter, this can be a valid bug of Horizon (Low or Wish List priority).

Thanks

Changed in horizon:
status: New → Incomplete
Revision history for this message
Tanja Roth (taroth) wrote :

My main concern was that the button title does not fit very well - something like "Manage Roles" would fit better, IMHO.

Akihiro Motoki (amotoki)
summary: - Editing Security Rules
+ "Edit Rules" in Security Group tab should be a better name
Changed in horizon:
importance: Undecided → Low
status: Incomplete → Triaged
assignee: nobody → Akihiro Motoki (amotoki)
Revision history for this message
Harikrishna (harikrishna-mallavolu) wrote :

Akhilo Motoki - Are you still working on this bug??

Revision history for this message
Julie Pichon (jpichon) wrote :

Unassigning due to inactivity.

Changed in horizon:
assignee: Akihiro Motoki (amotoki) → nobody
mariam john (mariamj)
Changed in horizon:
assignee: nobody → mariam john (mariamj)
mariam john (mariamj)
Changed in horizon:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80399

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/80399
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8b84361d590bf2bb5191a71932033a8a115a7abc
Submitter: Jenkins
Branch: master

commit 8b84361d590bf2bb5191a71932033a8a115a7abc
Author: <email address hidden> <email address hidden>
Date: Thu Mar 13 15:57:56 2014 -0400

    Changed the label from Edit Rules to Manage Rules

    In the Access & Security' category under Project tab,
    for each security group, there is an option to edit
    the rules. Clicking this button, lists all the rules
    for a given security group and from there we can
    add/delete rules. Since there is no support for security
    group rule editing provided by Nova/Neutron, in this fix
    the label of the 'Edit Rules' button was changed to
    'Manage Rules' instead.

    Closes-Bug: 1210513

    Change-Id: I644c95b2f0147f5f59b543fd1eb9748ee4eb7e19

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.