Midori Web Browser

New context menus regress a couple tidbits

Bug #1209375 reported by gue5t gue5t on 2013-08-07

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Midori Web Browser	Fix Released	High	Cris Dywan	Midori Web Browser 0.5.5 "Apples and Oranges"

Compared to the old context menus we change several things unintentionally that need to be fixed:

We swap the order of "undo/redo" to "redo/undo", so it no longer matches the edit menu in the menubar.

We make "delete" sensitive even if no text is selected.

We don't include the input method/unicode entry items.

See the attached before (top)/after (bottom) screenshot.

Tags:

Merged into lp:midori at revision 6341

gue5t gue5t: Approve on 2013-08-11

Merged into lp:midori at revision 6342

Cris Dywan: Approve on 2013-08-12

Revision history for this message

gue5t gue5t (gue5t) wrote on 2013-08-07:

Revision history for this message

gue5t gue5t (gue5t) wrote on 2013-08-07:

The screenshot doesn't show it, but it appears that the icon for "open in new window" is no longer shown, either (when that item is shown).

Cris Dywan (kalikiana) on 2013-08-08

Changed in midori:
milestone:	none → 0.5.5-freeze
assignee:	nobody → Christian Dywan (kalikiana)
importance:	Undecided → High
status:	New → Confirmed

Revision history for this message

Cris Dywan (kalikiana) wrote on 2013-08-08:

I can see the icon for 'Open in New Window' just fine. And the same stock ID is used in the code.

Revision history for this message

Cris Dywan (kalikiana) wrote on 2013-08-08:

The latest GTK+ git removed 'Insert Unicode Entry' and 'Input Method' items as of https://git.gnome.org/browse/gtk+/commit/?id=4a62d19da79e83156e03b02382989c370e27e151 - it might seem there's not much sense in adding them back. Personally I've never found them useful - except for keeping up with mirroring what GTK+ has built-in.