AttributeError: 'MockClient' object has no attribute 'EXTED_PLURALS'

[Nachi Ueno]

Some neutronclient change brokes nova unit test. and breaks also gating.

2013-08-07 17:28:59.861 | Traceback (most recent call last):
2013-08-07 17:28:59.861 | File "/home/jenkins/workspace/gate-nova-python27/nova/tests/api/ec2/test_cloud.py", line 2846, in test_create_delete_security_group
2013-08-07 17:28:59.862 | self.assertTrue(delete(self.context, 'testgrp'))
2013-08-07 17:28:59.862 | File "/home/jenkins/workspace/gate-nova-python27/nova/api/ec2/cloud.py", line 746, in delete_security_group
2013-08-07 17:28:59.862 | group_id)
2013-08-07 17:28:59.863 | File "/home/jenkins/workspace/gate-nova-python27/nova/network/security_group/neutron_driver.py", line 125, in get
2013-08-07 17:28:59.863 | neutron, 'security_group', name)
2013-08-07 17:28:59.863 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/neutronclient/neutron/v2_0/__init__.py", line 46, in find_resourceid_by_name_or_id
2013-08-07 17:28:59.864 | resource_plural = _get_resource_plural(resource, client)
2013-08-07 17:28:59.864 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/neutronclient/neutron/v2_0/__init__.py", line 38, in _get_resource_plural
2013-08-07 17:28:59.864 | plurals = client.EXTED_PLURALS
2013-08-07 17:28:59.864 | AttributeError: 'MockClient' object has no attribute 'EXTED_PLURALS'

https://jenkins01.openstack.org/job/gate-nova-python27/86/console

[Nachi Ueno (nati-ueno)]

https://review.openstack.org/#/c/33187/ looks cause of this issue

[Nachi Ueno (nati-ueno)]

This line is the cause.

https://github.com/openstack/python-neutronclient/blob/master/neutronclient/neutron/v2_0/__init__.py#L38

IMO, the code itself looks good, but nova unit test should change the way to mock neutron client.

so The nova UT change should be before neutron client change.
I would like to revert 33187.

[Mark McClain (markmcclain)]

Long term we need to update the MockClient in Nova, but I think we should clean up a few things in python client first.

[Russell Bryant (russellb)]

looks like this was fixed and not an issue in nova