Don't inject files while resizing instance

Bug #1208680 reported by wangpan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
wangpan

Bug Description

As the code owner of method 'finish_migration' in libvirt driver, the files injecting operation is not necessary during resize, because they have already injected when creating the instance, so add a parameter to fix this issue.

def finish_migration(self, context, migration, instance, disk_info,
                         network_info, image_meta, resize_instance,
                         block_device_info=None, power_on=True):
    ......
    # TODO(oda): injecting files is not necessary
    self._create_image(context, instance,
                           disk_mapping=disk_info['mapping'],
                           network_info=network_info,
                           block_device_info=None)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/40354

Changed in nova:
assignee: nobody → wangpan (hzwangpan)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/40354
Committed: http://github.com/openstack/nova/commit/68b6d1e31ffdc77aae8b9bad2c769109bb5473dd
Submitter: Jenkins
Branch: master

commit 68b6d1e31ffdc77aae8b9bad2c769109bb5473dd
Author: Wangpan <email address hidden>
Date: Tue Aug 6 14:10:57 2013 +0800

    Don't inject files while resizing instance

    Fixes bug 1208680

    As what the code owner of method 'finish_migration' in libvirt driver
    said, the files injecting operation is not necessary during resize,
    because they have already been injected when creating the instance,
    so added a parameter to _create_image to fix this issue, which is used
    for identifying the injection is needed or not.

    Change-Id: I01990de0ad2c7f1c2e499144034b7a4ac9faf024

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.