Clarify error message in Mahara syntax checker about table names with {}

Bug #1208287 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Aaron Wells
1.6
Fix Released
Low
Aaron Wells
1.7
Fix Released
Low
Aaron Wells

Bug Description

I keep getting false positives from this syntax check:

        if (/\b(from|join)\s[^({]/i) {
            bad_line("this sql table is not surrounded by curly braces {}, ".
                     "or is not an anonymous inner select", $_);
        }

That's because it kicks in if you have comments including the very common preposition "from", or less frequently the word "join". I'm going to change the text in the Makefile to clarify what's triggering the message.

Tags: gerrit
Revision history for this message
Aaron Wells (u-aaronw) wrote :
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.