Midori Web Browser

Context menu action in private mode throws errors

Bug #1207724 reported by André Stösel
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Medium
Cris Dywan
Midori Web Browser 0.5.5 "Apples and Oranges"

Bug Description

If you use the context menu in private mode to open a link in a new tab or search for stuff it throws a g-crititcal-error.

Related branches

lp:~kalikiana/midori/ctxtabnew
André Stösel: Approve
Diff: 113 lines (+38/-35)
1 file modified
midori/midori-view.c (+38/-35)
André Stösel (ivaldi)
tags: added: context menu
Changed in midori:
status: New → Confirmed
milestone: none → 0.5.5
tags: added: context-menu pirvate-mode
removed: context menu
Revision history for this message
gue5t gue5t (gue5t) wrote :

This is happening for me in non-private mode on <http://reddit.com/r/programming/>, but only on the first time it's tried after loading the page. That is, to reproduce, follow the steps exactly: load <http://reddit.com/r/programming/> in a tab, right-click one of the articles' links. Four critical str warnings will appear, followed by a crash if you choose "open in new tab". If you close the menu and try again, no warnings or crashes are generated the second time unless you reload the page.

tags: added: privatebrowsing
removed: pirvate-mode
Revision history for this message
Cris Dywan (kalikiana) wrote :

It would help a lot as a general rule to say *what* criticals were seen otherwise this bug can retroactively refer to just about anything…

Changed in midori:
status: Confirmed → Incomplete
Revision history for this message
Cris Dywan (kalikiana) wrote :

I cannot repro but I can see a way for a crash in strchr under a specific condition; I'll come up with a way to make it more robust.

Changed in midori:
status: Incomplete → Confirmed
assignee: nobody → Christian Dywan (kalikiana)
Cody Garver (codygarver)
Changed in midori:
importance: Undecided → Medium
status: Confirmed → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.