remove run_filter_once_per_request from GroupAntiAffinityFilter

Bug #1206502 reported by Guangya Liu (Jay Lau)
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Gary Kotton

Bug Description

Now GroupAntiAffinityFilter was defined to run once per request, but this is not right, as filter_properties['group_hosts'] will be updated after one host was selected for one VM. So if there are multiple VMs in one request, the VM deployment will not obey GroupAntiAffinityFilter, as some VMs might be deployed on to same host with current VMs.

Changed in nova:
assignee: nobody → Jay Lau (jay-lau-513)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/39286

Changed in nova:
status: New → In Progress
Changed in nova:
assignee: Jay Lau (jay-lau-513) → Gary Kotton (garyk)
Gary Kotton (garyk)
Changed in nova:
milestone: none → havana-rc1
importance: Undecided → Medium
Revision history for this message
Russell Bryant (russellb) wrote :

Marked as Incomplete and put on the RC potential list since the patch is currently abandoned

tags: added: havana-rc-potential
Changed in nova:
milestone: havana-rc1 → none
status: In Progress → Incomplete
Revision history for this message
Guangya Liu (Jay Lau) (jay-lau-513) wrote :

Hi Russell, it is going to be merged now: https://review.openstack.org/#/c/45571/

Seems launchpad did not catch the new patch, here I just mark the issue as "Fix Committed ". Thanks.

Changed in nova:
status: Incomplete → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/45571
Committed: http://github.com/openstack/nova/commit/4233e16ba2f5bb85e93494b6eeb9ffff31dbdf30
Submitter: Jenkins
Branch: master

commit 4233e16ba2f5bb85e93494b6eeb9ffff31dbdf30
Author: Gary Kotton <email address hidden>
Date: Sun Sep 8 04:29:24 2013 -0700

    Ensure anti affinity scheduling works

    The query for the group in the system_metadata would not correctly
    filter the instances with the groups.

    In addition to this change 4a03071db23196c4ac1ec0d8ea163c46887d3b08
    ensured that the scheduling filter was only run once.
    In cases when provisioning fails and rescheduling
    takes place the filter must be invoked (if it is in the filter tool
    chain).

    Fixes bug: 1218878
    Fixes bug: 1206502

    Change-Id: I623c73635c36ffa038ae01476a25ba0c0863e536

Changed in nova:
milestone: none → havana-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-rc1 → 2013.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/55154

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.