Autosave leads to crash on replays
Bug #1206441 reported by
wl-zocker
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
High
|
cghislai | ||
Bug Description
tested with r6880.
Steps to reproduce:
- Set the autosave interval to 1 minute.
- Watch the replay of any game.
After one minute of real time, Widelands crashes (game speed does not influence the time). The stdout says "Autosave: interval elapsed (60 s), saving".
I think autosave in replays is not necessary and should not take place.
Related branches
lp:~widelands-dev/widelands/log_messages
- SirVer: Needs Information
-
Diff: 1271 lines (+343/-161)35 files modifiedsrc/chat.cc (+100/-1)
src/chat.h (+1/-6)
src/debugconsole.cc (+0/-4)
src/gamecontroller.cc (+2/-30)
src/log.h (+0/-1)
src/logic/game.cc (+3/-1)
src/logic/game.h (+4/-1)
src/logic/immovable.cc (+1/-0)
src/logic/notification.h (+1/-2)
src/logic/player.cc (+1/-1)
src/logmessage.h (+41/-0)
src/network/internet_gaming.cc (+0/-9)
src/network/internet_gaming.h (+0/-3)
src/network/netclient.cc (+0/-9)
src/network/netclient.h (+1/-1)
src/network/nethost.cc (+0/-7)
src/save_handler.cc (+8/-11)
src/ui_basic/panel.h (+1/-1)
src/ui_basic/unique_window.cc (+2/-2)
src/ui_basic/window.cc (+15/-6)
src/ui_basic/window.h (+1/-0)
src/wlapplication.cc (+3/-1)
src/wui/chatoverlay.cc (+86/-18)
src/wui/chatoverlay.h (+3/-0)
src/wui/game_main_menu_save_game.cc (+11/-9)
src/wui/game_main_menu_save_game.h (+3/-1)
src/wui/gamechatpanel.cc (+2/-1)
src/wui/interactive_base.cc (+14/-0)
src/wui/interactive_base.h (+12/-0)
src/wui/interactive_gamebase.cc (+3/-4)
src/wui/interactive_gamebase.h (+4/-3)
src/wui/interactive_player.cc (+3/-9)
src/wui/interactive_player.h (+0/-3)
src/wui/interactive_spectator.cc (+9/-11)
src/wui/watchwindow.cc (+8/-5)
Revision history for this message
| cghislai (charlyghislain) wrote | #1 |
Revision history for this message
| cghislai (charlyghislain) wrote | #2 |
| Changed in widelands: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| assignee: | nobody → cghislai (charlyghislain) |
| milestone: | none → build18-rc1 |
| Changed in widelands: | |
| status: | Confirmed → In Progress |
Revision history for this message
| SirVer (sirver) wrote | #3 |
Revision history for this message
| cghislai (charlyghislain) wrote | #4 |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| SirVer (sirver) wrote | #5 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I agree that autosave may not be required for replays. But since saving during replay is allowed, the crash should not occur.