Resource creation error when some remained on OFC (NEC Plugin)

Bug #1206416 reported by Ryota Mibu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Ryota Mibu

Bug Description

NEC Plugin ignores OFC (= OpenFlow Controller, which is backend of this plugin) errors while deleting resources (network and port) from OFC, and it could leave some unused resources on OFC. If OFC/OFC-driver generates id which is in remained resources on OFC when creating new one, OFC will fail to create it.

How easy to generate duplicated ids depend on OFC or OFC-driver, but we have to consider this situation. So we will make NEC Plugin keep logical resource which had OFC error while deleting, to make sure there is no orphan resource on OFC.

Tags: nec
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/39235

Changed in neutron:
assignee: nobody → Ryota Mibu (r-mibu)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/39235
Committed: http://github.com/openstack/neutron/commit/49e953a8ef9d552e9c5be1e2e807634c68af5c5f
Submitter: Jenkins
Branch: master

commit 49e953a8ef9d552e9c5be1e2e807634c68af5c5f
Author: Ryota MIBU <email address hidden>
Date: Mon Jul 29 22:07:19 2013 +0900

    Make NEC Plugin keep error resources

    NEC Plugin used to ignore OFC errors while deleting resources from OFC,
    and it could leave some unused resources on OFC. If OFC generates id
    which is in remained resources when creating new resource, it will fail.

    This commit makes NEC Plugin keep logical resource when it failed to
    delete resource from OFC not to leave orphan resource on OFC, and raise
    exception to tell the user that the resouce status is Error.

    NOTE: The user can retry deletion. If the resouce was successfully
    deleted from OFC in retries, the logical resource will be deleted.

    Fixes: bug #1206416
    Change-Id: Ifea38dfe3fe8b18d7ae1cedf86a23008549250cc

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → havana-3
Changed in neutron:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.