Batch Search / Replace function errors out

[Rob Peters]

This error exist in SVN 15354 as well as standard 1.4.3/

Setting a Search Text and a Replace Text and then doing multiple next's, the following error is generated:

[Sun Jul 28 08:14:51 2013] [error] [client 127.0.0.1] PHP Fatal error: Call to a member function getClientIp() on a non-object in /home/rob/www/includes/session.php(309) : runtime-created function on line 1, referer: http://localhost/index.php

No errors are detected in the database.

[Rob Peters (makitso)]

Search for California with a Replace of California does not get the error. But, if the Replace is changed to California, USA then the error occurs. It appears that the problem is when the searched text is in a note.

[fisharebest (fisharebest)]

I have no problem using S/R on notes - even changing "California" to "California, USA".

But I do run into the known problem of stack-overflow when there is a record with many instances of "California". There is another bug report about that.

[Rob Peters (makitso)]

That may be it. If there are multiple PLAC records that match the Search e.g. Wisconsin and replace Wisconsin, USA it fails. See example below.

1 NAME Henry L. /Peters/
2 GIVN Henry L.
2 SURN Peters
1 SEX M
1 BIRT
2 DATE 15 SEP 1888
2 PLAC Apeldoorn, Gelderland, Netherlands
1 DEAT
2 DATE 1965
2 PLAC Dodge Co, Wisconsin
1 EVEN
2 TYPE SSN
2 NOTE Description: 399-32-6585
1 FAMC @F132@
1 FAMS @F151@
1 CHAN
2 DATE 28 JUL 2013
3 TIME 12:39:51
2 _WT_USER petersra
1 IMMI
2 DATE 1895
2 PLAC Apeldoorn, Gelderland, Netherlands
1 BURI
2 CEME Alto
2 PLAC Alto, Fond Du Lac Co, Wisconsin

[meliza (meliza)]

I try to run the Admin Batch Search and Replace to change Neve Monosson to Neve Monoson.

I see 2 individuals who have Neve Monosson in their text. After that the program runs and runs and after some time I see on the page link "Pending changes" and a second 'page' with the top of the page text webtrees and the 3 page times.
I try to click on the Pending changes link - nothing happens. The linked URL looks odd. I was not asked to update?
Also the top Pending changes link does nothing.
On other pages I can click the Pending changes link, no new changes were added, as expected.

Before this run I tried to replace Monosson by Monoson and I saw no individual, only after some time the Pending changes texts.

I see in the log
[18-Oct-2013 14:17:31 UTC] PHP Fatal error: Maximum execution time of 500 seconds exceeded in /home/meliza/public_html/build/webtrees/modules_v3/batch_update/admin_batch_update.php on line 398

Meliza

[fisharebest (fisharebest)]

I've replaced the LCS-based algorithm with the Myers algorithm (which is faster and uses fewer resources).