attempt to renew in TPAC can result in an Apache internal server error

[Galen Charlton]

Attempting to renew an item that requires a rental or deposit in TPAC will result an an Apache internal server error. The corresponding log entry is:

egweb: template error: undef error - No field by the name fail_part in Fieldmapper::asset::copy! at /usr/local/share/perl/5.10.1/OpenILS/Utils/Fieldmapper.pm line 284.\n, referer: https://example.org/eg/opac/myopac/circs

The myopac/circs.tt2 template contains references to circ.renewal_response.payload.fail_part; this is a problem because the payload of an event response from open-ils.circ.renew is a asset::copy object, not a hash that might contain a fail_part key -- at least when the ITEM_RENTAL_FEE_REQUIRED or ITEM_DEPOSIT_REQUIRED events are returned. I haven't yet verified what the payload looks like if the renewal fails because of (say) a failure to find a matching circ matrix entry.

Evergreen 2.3+

[Galen Charlton (gmc)]

A patch is available at the tip of the user/gmcharlt/lp1205492_graceful_rental_renew_handling_in_tpac branch in the working repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1205492_graceful_rental_renew_handling_in_tpac

[Mike Rylander (mrylander)]

Picked into rel_2_9 - master. Thanks, Galen!