Only show close buttons for active or hovered tabs
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Granite |
Fix Released
|
Wishlist
|
Victor Martinez |
Bug Description
Something I noticed Safari does that is very interesting is only show close buttons on Active or Hovered tabs. I think it's important to distinguish that the close button appears not just when that area of the tab is hovered but if any part of the tab is hovered. We could consider even go a step further and say if any part of the tabbar is hovered. I like this for two reasons:
1. It reduces visual noise. Having the close button over and over and over gets very noisy.
2. For touch it means that you can't accidentally hit the close button when you meant to select a tab instead. However showing the close button when the tab is active means that it's still accessible (which it wouldn't be if we showed it only on hover).
Related branches
- Cody Garver (community): Needs Fixing
- David Gomes (community): Needs Fixing
-
Diff: 124 lines (+68/-0)1 file modifiedlib/Widgets/DynamicNotebook.vala (+68/-0)
- David Gomes (community): Approve
-
Diff: 351 lines (+139/-45)1 file modifiedlib/Widgets/DynamicNotebook.vala (+139/-45)
Changed in granite: | |
status: | New → Confirmed |
milestone: | none → 0.3-beta1 |
Changed in granite: | |
milestone: | isis-beta1 → 0.3.1 |
Changed in granite: | |
status: | Confirmed → In Progress |
assignee: | nobody → Victor Martinez (victored) |
Changed in granite: | |
status: | In Progress → Fix Committed |
Changed in granite: | |
milestone: | 0.3.1 → isis-beta1 |
Changed in granite: | |
status: | Fix Committed → Fix Released |
One problem I noticed with this is that you have to click to a tab to close it on touch.