Errors while compiling version 1.5.2

[jean-christophe manciot]

Environment: Ubuntu 13.04

"hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:
hw/ide/macio.c:215:5: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int64_t’ [-Werror=format]
hw/ide/macio.c:222:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
hw/ide/macio.c:264:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
cc1: all warnings being treated as errors
make: *** [hw/ide/macio.o] Error 1"

I got the source files with a "git clone git://git.qemu-project.org/qemu.git" + a recent "git fetch"

[jean-christophe manciot (manciot-jeanchristophe)]

I was able to compile and link latest 1.5.2 release with the tar.bz2 source files.

[jean-christophe manciot (manciot-jeanchristophe)]

I'm glad that ASAs do not crash anymore within GNS3 with this latest qemu release: nice work guys! :)

[Michael Roth (mdroth)]

Quoting Stefan Weil (2013-07-26 00:12:59)
> Am 26.07.2013 04:03, schrieb jean-christophe manciot:
> > Public bug reported:
> >
> > Environment: Ubuntu 13.04
> >
> > "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
> > hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:
> > hw/ide/macio.c:215:5: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int64_t’ [-Werror=format]
> > hw/ide/macio.c:222:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > hw/ide/macio.c:264:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > cc1: all warnings being treated as errors
> > make: *** [hw/ide/macio.o] Error 1"
> >
> > I got the source files with a "git clone git://git.qemu-
> > project.org/qemu.git" + a recent "git fetch"
> >
> > ** Affects: qemu
> > Importance: Undecided
> > Status: New
> >
>
>
>
> This patch should fix it: http://patchwork.ozlabs.org/patch/258774/.
>
> It's also still missing in git master, but was already applied to
> qemu-trivial.

This doesn't seem to be vanilla 1.5.2, where 04dd1259 isn't applicable
(no MACIO_DPRINTF statements), but rather a newer release or past
version with this patch on top:

  commit 80fc95d8bdaf3392106b131a97ca701fd374489a
  Author: Alexander Graf <email address hidden>
  Date: Fri Jun 28 13:30:01 2013 +0200

      PPC: dbdma: Support unaligned DMA access

I'd pull them both in if Alex wants to send a backported version for
1.5.2, but otherwise this doesn't seem to be an issue with stable.

>
> Stefan

[Michael Roth (mdroth)]

Quoting Michael Roth (2013-08-12 20:05:32)
> Quoting Stefan Weil (2013-07-26 00:12:59)
> > Am 26.07.2013 04:03, schrieb jean-christophe manciot:
> > > Public bug reported:
> > >
> > > Environment: Ubuntu 13.04
> > >
> > > "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
> > > hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > > hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:
> > > hw/ide/macio.c:215:5: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int64_t’ [-Werror=format]
> > > hw/ide/macio.c:222:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > > hw/ide/macio.c:264:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > > cc1: all warnings being treated as errors
> > > make: *** [hw/ide/macio.o] Error 1"
> > >
> > > I got the source files with a "git clone git://git.qemu-
> > > project.org/qemu.git" + a recent "git fetch"
> > >
> > > ** Affects: qemu
> > > Importance: Undecided
> > > Status: New
> > >
> >
> >
> >
> > This patch should fix it: http://patchwork.ozlabs.org/patch/258774/.
> >
> > It's also still missing in git master, but was already applied to
> > qemu-trivial.
>
> This doesn't seem to be vanilla 1.5.2, where 04dd1259 isn't applicable
> (no MACIO_DPRINTF statements), but rather a newer release or past
> version with this patch on top:
>
> commit 80fc95d8bdaf3392106b131a97ca701fd374489a
> Author: Alexander Graf <email address hidden>
> Date: Fri Jun 28 13:30:01 2013 +0200
>
> PPC: dbdma: Support unaligned DMA access
>
> I'd pull them both in if Alex wants to send a backported version for
> 1.5.2, but otherwise this doesn't seem to be an issue with stable.

Forgot to cc Alex.

>
> >
> > Stefan

[agraf (agraf)]

Am 13.08.2013 um 03:07 schrieb Michael Roth <email address hidden>:

> Quoting Michael Roth (2013-08-12 20:05:32)
>> Quoting Stefan Weil (2013-07-26 00:12:59)
>>> Am 26.07.2013 04:03, schrieb jean-christophe manciot:
>>>> Public bug reported:
>>>>
>>>> Environment: Ubuntu 13.04
>>>>
>>>> "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
>>>> hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
>>>> hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:
>>>> hw/ide/macio.c:215:5: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int64_t’ [-Werror=format]
>>>> hw/ide/macio.c:222:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
>>>> hw/ide/macio.c:264:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
>>>> cc1: all warnings being treated as errors
>>>> make: *** [hw/ide/macio.o] Error 1"
>>>>
>>>> I got the source files with a "git clone git://git.qemu-
>>>> project.org/qemu.git" + a recent "git fetch"
>>>>
>>>> ** Affects: qemu
>>>> Importance: Undecided
>>>> Status: New
>>>
>>>
>>>
>>> This patch should fix it: http://patchwork.ozlabs.org/patch/258774/.
>>>
>>> It's also still missing in git master, but was already applied to
>>> qemu-trivial.
>>
>> This doesn't seem to be vanilla 1.5.2, where 04dd1259 isn't applicable
>> (no MACIO_DPRINTF statements), but rather a newer release or past
>> version with this patch on top:
>>
>> commit 80fc95d8bdaf3392106b131a97ca701fd374489a
>> Author: Alexander Graf <email address hidden>
>> Date: Fri Jun 28 13:30:01 2013 +0200
>>
>> PPC: dbdma: Support unaligned DMA access
>>
>> I'd pull them both in if Alex wants to send a backported version for
>> 1.5.2, but otherwise this doesn't seem to be an issue with stable.
>
> Forgot to cc Alex.

I'd rather not backport these to 1.5, as the patches only make sense as a whole with an OpenBIOS update.

IIUC the compile error has been fixed for 1.6, correct?

Alex

>
>>
>>>
>>> Stefan

[Michael Roth (mdroth)]

Quoting Alexander Graf (2013-08-12 23:06:19)
> Am 13.08.2013 um 03:07 schrieb Michael Roth <email address hidden>:
>
> > Quoting Michael Roth (2013-08-12 20:05:32)
> >> Quoting Stefan Weil (2013-07-26 00:12:59)
> >>> Am 26.07.2013 04:03, schrieb jean-christophe manciot:
> >>>> Public bug reported:
> >>>>
> >>>> Environment: Ubuntu 13.04
> >>>>
> >>>> "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
> >>>> hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> >>>> hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:
> >>>> hw/ide/macio.c:215:5: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int64_t’ [-Werror=format]
> >>>> hw/ide/macio.c:222:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> >>>> hw/ide/macio.c:264:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> >>>> cc1: all warnings being treated as errors
> >>>> make: *** [hw/ide/macio.o] Error 1"
> >>>>
> >>>> I got the source files with a "git clone git://git.qemu-
> >>>> project.org/qemu.git" + a recent "git fetch"
> >>>>
> >>>> ** Affects: qemu
> >>>> Importance: Undecided
> >>>> Status: New
> >>>
> >>>
> >>>
> >>> This patch should fix it: http://patchwork.ozlabs.org/patch/258774/.
> >>>
> >>> It's also still missing in git master, but was already applied to
> >>> qemu-trivial.
> >>
> >> This doesn't seem to be vanilla 1.5.2, where 04dd1259 isn't applicable
> >> (no MACIO_DPRINTF statements), but rather a newer release or past
> >> version with this patch on top:
> >>
> >> commit 80fc95d8bdaf3392106b131a97ca701fd374489a
> >> Author: Alexander Graf <email address hidden>
> >> Date: Fri Jun 28 13:30:01 2013 +0200
> >>
> >> PPC: dbdma: Support unaligned DMA access
> >>
> >> I'd pull them both in if Alex wants to send a backported version for
> >> 1.5.2, but otherwise this doesn't seem to be an issue with stable.
> >
> > Forgot to cc Alex.
>
> I'd rather not backport these to 1.5, as the patches only make sense as a whole with an OpenBIOS update.

Ok, makes sense, just thought I'd double-check. Got the impression from the bug
report that maybe some downstreams were carrying your patch on top of 1.5.2 for
OSX support, but I'm not really sure what's going on here.

>
> IIUC the compile error has been fixed for 1.6, correct?

Yup, should be fixed upstream with 04dd1259

>
>
> Alex
>
> >
> >>
> >>>
> >>> Stefan

[Thomas Huth (th-huth)]

Marking this ticket as "Fix released" according to comment #6.