Margin should be all Drawables' property.

[Jakub Sękowski]

I suggest to add member "margin" and method "SetMargin" to Drawable class definition. Why only Boxes may have it?

[Rafał Cieślak (rafalcieslak256)]

You may find it much much more convenient to fix this bug once https://code.launchpad.net/~rafalcieslak256/millenniumduel/cached-redrawing/ is merged (I'm going to send a MP asap).

[Jakub Sękowski (sequba)]

I was thinking about this issue for a while and my idea is to make "_margin" a private member of IDrawable (similar to "_background_color"). But this will cause some problems.

A lot of methods, such as OnClicked(...) and GetMinimal...(...), have to be able to determine widget's margin, so I suggest, to use similar trick to the one, Rafał did with Draw(...) - make those functions non-virtual public methods of IDrawable and specify something like OnClickedNoMargin(...) and GetMinimal...NoMargin(...) (analogous to Redraw(...)), which will ignore widget's margin completely.

However, I'm not sure if this is the right way to do it. Otherwise, I can just specify public "getter" method GetMargin(), which, obviously, would be called by OnClicked(...) and GetMinimal...(...), but approach is completely different to the "_background_color"-one.

What do you think about it?

[Rafał Cieślak (rafalcieslak256)]

This is *exactly* the way I would do it. It's a pretty flexible approach, and it simplifies widget-specific code as much as possible.

I would, however, reconsider naming. Names containing "NoMargin" would be silly to call, because whatever wants to use them, would imply that it is interested in a particular version of the width/height.

Maybe names as "GetMinimalHeight" and "GetTotalMinimalHeight" or "GetInnerMinimalHeight" and "GetMinimalHeight" would be more clear.
Personally, I'd go for the second option, because it can be extended to OnClicked: IDrawable's "OnClicked" would call widget-specific methods "OnMarginClicked" and "OnInnerClicked".
"Insides" instead of "Inner" could do the trick too.

[Jakub Sękowski (sequba)]

Thanks a lot. Yesterday I was just about to start implementing it, but I wasn't concerned so I decided to wait for someone to approve my ideas.

You're right. Those names was just sample for better description of the "trick". I like the "Inner"-style too.