bugs introduced with making state not required

Bug #1204273 reported by Ben Shum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned

Bug Description

Evergreen master

When we merged bug 1079041, we introduced a few unexpected problems by making state not required for user addresses:

1) The library settings were created with "au" instead of "aua" and thus the UI wasn't picking them up and leaving the field as not required even if the settings were made.

2) The auditor logs still include a NOT NULL requirement from upgraded systems, so there'd be errors trying to insert NULL values to the table.

In response, I worked with tsbere to whip up a branch to address these issues by changing the name of the library settings to fit correctly and also fixing the auditor table. Along the way, we discovered that the table config.org_unit_setting_type_log which tracks library settings was inflexible and needed to be adjusted with "DEFERRED INITIALLY DEFERRABLE" in order to allow us to make the necessary fixes.

Will attach working branch once I have the bug number.

Tags: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :
tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Actually that's supposed to be "DEFERRABLE INITIALLY DEFERRED".

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Thanks, Ben!

Fixes the problems in my development environment, and we've used a version of this in production for over a week, now.

Pushed to master.

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.