edit button dialog looks out of place
Bug #1202084 reported by
Dinko Osmankovic
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Sudoku App |
Fix Released
|
Undecided
|
Frédéric Delgado |
Bug Description
The current implementation really looks out of place when adding new suru styling. It uses DefaultSheet which cannot be themed currently.
This is actually very simple to do: Just change DefaultSheet to Dialog, and it will look much better.
Related branches
lp:~fredoust/sudoku-app/fix-bug-1202084
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Dinko Osmankovic: Approve
-
Diff: 679 lines (+341/-325)1 file modifiedsudoku-app.qml (+341/-325)
Changed in sudoku-app: | |
assignee: | nobody → Frédéric Delgado (fredoust) |
Changed in sudoku-app: | |
status: | In Progress → Fix Committed |
Changed in sudoku-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi, I changed the two defaultSheet to dialog, and I added a cancel button, is that what you wanted ?