Strip Search goes beyond track's usable waveform

[x]

When using strip search on my VMS4.1, the strip-searching causes the track's waveform to scroll far past the area where there would actually be audio playing. For example, touching the bottom of the touchpad on my VMS4.1 causes the waveform to scroll to where there are only the "no waveform triangles" visible and there is no cursor in the overview.

[Owen Williams (ywwg)]

sigh, this is because of my vinyl preroll hack. We have to figure out how to make preroll work without messing up seek for everyone else.

[Daniel Schürmann (daschuer)]

I had a look at the current res/controllers/American-Audio-VMS4-scripts.js, but I cannot find a place where the CO "playposition" is used. Do you have a custom script?
You may change it in a way that the Midi values14 becomes Position 0 and 114 End position.
I will add this info to http://mixxx.org/wiki/doku.php/mixxxcontrols as well.

[RJ Skerry-Ryan (rryan)]

OK! I think we should revert the playposition -0.14 - 1.14 range to 0-1 and make it allow out of range sets.

This way we can stop messing up MIDI controllers and contain the logic just within VC.

[Daniel Schürmann (daschuer)]

Hi RJ,

Please do not shoot to quick here. We have a pending discussion about the out of bounds parameter.
IMHO the solution is currently incomplete. We should collect all aspects somewhere and decide after having the whole picture in place.
See: Bug #1294750

This could also be a controller bug or no bug. Maybe some use case require to seek to the pre-role.
Do we have or know the effected script?

@Owen: What is your opinion here? I might remember we hard already a fix and revert cycle.

[RJ Skerry-Ryan (rryan)]

Just followed up on Bug #1294750, I think the current fix is the right one.

I ran this by Owen before commenting and he was on board with moving this VC-specific logic into VC.

[Daniel Schürmann (daschuer)]

What means VC?
If you have double checked that it is Ok, it is fine. But I am afraid there are many implicit dependencies.

related:
Bug #864590
https://github.com/mixxxdj/mixxx/commit/bc4188a5ebf683eba68c59395daea75cdd250da1
Bug #1087437

[Owen Williams (ywwg)]

VC == Vinyl Control. Vinyl Control needs to be able to seek to positions before track start to allow for proper scratching of the start of a track.

[RJ Skerry-Ryan (rryan)]

https://github.com/mixxxdj/mixxx/pull/220

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7105