handle-remaining-connect-fails-cases-in-solidfire-driver

[John Griffith]

When fixing bug/1195910, some other failure cases weren't considered (ie not authorized, unreachable dest etc). We should fix this up to handle the various connection error states accordingly and also add some hints to the log output to help determine where to look in case of failure.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/37136

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/37136
Committed: http://github.com/openstack/cinder/commit/5edbc4eb9a6b0d50612fffb6261850c80515b483
Submitter: Jenkins
Branch: master

commit 5edbc4eb9a6b0d50612fffb6261850c80515b483
Author: John Griffith <email address hidden>
Date: Mon Jul 15 15:16:25 2013 -0600

    Catch additional connect fail cases.

    When fixing bug/1195910, some other failure
    cases weren't considered (ie not authorized,
    unreachable dest etc).

    We should fix this up to handle the various
    connection error states accordingly and also
    add some hints to the log output to help
    determine where to look in case of failure.

    Fixes bug: 1201592

    Change-Id: Ib099c7af705e7c49be4d0f723c8a20262c942e7f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/37321

[John Griffith (john-griffith)]

There are two issues associated with this bug:
1. Not handling the exceptions resulting in a trace and crashing the cinder-volume service (unacceptable obvisouly)
2. The messaging doesn't provide enough info to determine what's wrong regarding the connection

Item 1 should be viewed as a critical issue, item 2 is a high priority.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/37321
Committed: http://github.com/openstack/cinder/commit/559b0fa33a8d4e248f50a9d1076e4ec3928f91a2
Submitter: Jenkins
Branch: stable/grizzly

commit 559b0fa33a8d4e248f50a9d1076e4ec3928f91a2
Author: John Griffith <email address hidden>
Date: Mon Jul 15 15:16:25 2013 -0600

    Catch additional connect fail cases.

    When fixing bug/1195910, some other failure
    cases weren't considered (ie not authorized,
    unreachable dest etc).

    We should fix this up to handle the various
    connection error states accordingly and also
    add some hints to the log output to help
    determine where to look in case of failure.

    Fixes bug: 1201592

    Change-Id: Ib099c7af705e7c49be4d0f723c8a20262c942e7f
    (cherry picked from commit 5edbc4eb9a6b0d50612fffb6261850c80515b483)