feature request: specify git branch and directory in YAML install steps

[Andrew McDermott]

It would be useful to be able to specify a branch to checkout when specifying a git repo in the install commands and the name of the directory where the clone should reside.

Right now I have two repo's with almost the same content for handling some minor differences between x86 and aarch64. I could do the git commands in the run steps but it seems natural to be able to have more control of the git clone command within the install steps.

For example:

install:
  git-repos:
    - git://git.linaro.org/people/andrew.mcdermott/mauve.git -b kvm-x86-64

OR:

install:
  git-repos:
    - git://git.linaro.org/people/andrew.mcdermott/mauve.git -b aarch64

If the git-repos line was to be executed as a complete git command then you could also specify a directory for the newly checked out repo. And this would then naturally extend to other git clone options.

For example.

install:
  git-repos:
    - git://git.linaro.org/people/andrew.mcdermott/mauve.git -b kvm-x86-64 mauve-kvm-86_64
    - git://git.linaro.org/people/andrew.mcdermott/mauve.git -b aarch64 mauve-aarch64

[Antonio Terceiro (terceiro)]

the problem with using those lines as git command lines is that we would
have to parse the command line somehow to avoid the risk of shell
command injection. IMO it's better to pass in the needed info already in
a structured way.

I already saw a syntax for this somewhere, but I can't recall exactly
where. Maybe we can use a something like this:

REPOURL#branch#directory

where everything but the REPOURL is optional.

[Antonio Terceiro (terceiro)]

A cleaner solution is to extend the schema to add new parameters to the repository specification so that we don't have to fiddle with parsing the repo URL in search of these other parameters.

[Antonio Terceiro (terceiro)]

argh - actually not, because these repos are referenced in the lava-test-shell test definition ... well, we need to think of a solution