html looks for yelp-code.png which is not there

Bug #1200987 reported by Doug Smythies
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Online publishing of the Ubuntu documentation
Fix Released
Undecided
Unassigned

Bug Description

the compiled HTML has many <div class="code"> tags, and the corresponding css entry wants to have a background with yelp-code.png. However the file is not there and we don't want it there. Thus, there are many entries in the web server error.log file. The definition of div.code should be revised to not include the yelp-code.png watermark.

Revision history for this message
Doug Smythies (dsmythies) wrote :

The issue is in the file /usr/share/yelp-xsl/xslt/common/html.xsl
here:

div.code {
  background: url('</xsl:text>
    <xsl:value-of select="$icons.code"/><xsl:text>') no-repeat top </xsl:text>
    <xsl:value-of select="$right"/><xsl:text>;
  border: solid 1px </xsl:text>
    <xsl:value-of select="$color.gray_border"/><xsl:text>;
}

where icons.code maps to yelp-code.png from within the file /usr/share/yelp-xsl/xslt/common/icons.xsl

we do not have control over that file, so we will have to override that definition with one in ubuntu.xls.

Revision history for this message
Doug Smythies (dsmythies) wrote :

Expanding this one to include ubuntu-docs, as the issue exists there also.
For ubuntu docs the issue is triggered by use of the <code>...</code> tag pairs in the source code.
For serverguide the issue is triggered by the use of the <programlisting>...</programlisting> tag pairs, and perhaps some others.

Revision history for this message
Doug Smythies (dsmythies) wrote :

For whatever reason, yelp-build is supposed to copy yelp-code.png over to the build directory during compile. It does for the other yelp-bla.png files that are needed, based on the actual source files. The following extract is cut and pasted from:

https://wiki.gnome.org/Yelp/Tools

"When creating HTML, yelp-build also outputs CSS and JavaScript files, as well as PNG files for icons and watermarks. What it outputs depends on what's in your document. ... For CSS, yelp-build creates a separate CSS file for each top-level language. For icons and watermarks, which images are copied depends on what types of admonitions and other elements you use."

So, I think the root issue here is actually with the yelp-xsl package. So far. my attempts at a workaround have not been successful. Even if there can be an override defined in ubuntu.xsl, it still seems to result in attempts to load the non-existent file (perhaps I don't have the override correct yet).

On this bug report, I am stuck and do not know how to proceed. I suppose I could add a manual copy over of the file to the Makefile. While we don't actually want the file, I did test with it present and didn't see any bad side effect of the watermark background (I should also try a much larger code block for a further test).

Revision history for this message
Doug Smythies (dsmythies) wrote :
Revision history for this message
Doug Smythies (dsmythies) wrote :

New yelp-xsl fixes this issue. It just has to make it way from gnome.org to here. We hope to push to have this in 14.04.

Changed in serverguide:
status: New → In Progress
Changed in ubuntu-docs (Ubuntu):
status: New → In Progress
affects: serverguide → help.ubuntu.com
no longer affects: ubuntu-docs (Ubuntu)
Revision history for this message
Doug Smythies (dsmythies) wrote :

After the upstream fix propagated down to Ubuntu, I forgot to set this to fix released.

Changed in help.ubuntu.com:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.