Nova should pass in page_size to python-glanceclient

Bug #1200233 reported by Jared Culp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Sumanth Nagadavalli

Bug Description

Nova has a --limit flag that can be passed thru the python-novaclient. Currently, images/glance.py in Nova needs to pass this value in as 'page_size' so that it can be properly interpreted by python-glanceclient.

Relevant pieces of code:
https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/shell.py#L81
https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/images.py#L175
https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v2/images.py#L49

Tags: api
Jared Culp (jared-culp)
affects: glance → nova
Changed in nova:
assignee: nobody → Jared Culp (jared-culp)
Jared Culp (jared-culp)
description: updated
summary: - python-glanceclient does not parse 'limit' option from nova
+ Nova should pass in page_size to python-glanceclient
melanie witt (melwitt)
tags: added: api
Changed in nova:
assignee: Jared Culp (jared-culp) → Sumanth Nagadavalli (sumanth-nagadavalli)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43262

Changed in nova:
status: New → In Progress
description: updated
description: updated
Andrew Laski (alaski)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/43262
Committed: http://github.com/openstack/nova/commit/d3aa5c59e0e2ed289d91d11b0fa3d15996aeac43
Submitter: Jenkins
Branch: master

commit d3aa5c59e0e2ed289d91d11b0fa3d15996aeac43
Author: Sumanth Nagadavalli <email address hidden>
Date: Thu Aug 29 10:27:08 2013 +0530

    Added 'page_size' param to image list

    Added a new query param called 'page_size' to
    accepted_query_params list in image list call.
    This param is passed on to glance-client which will
    be used to paginate the result set.

    Fixes bug 1200233

    Change-Id: I1c804c74c153e80bb572ec45283ebd9b6b7b41c5

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → havana-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.