Use-after-free in economy/economy.cc

[Hans Joachim Desserud]

Found by scan-build (llvm 3.3) in r6601

Note that these are two separate reports, though the issues are located in the same file (same function even), thus it probably makes sense to deal with them at the same time.

[SirVer (sirver)]

Both are false positives with the same root cause, pretty sure about this. But it not clear from the code that this is so, I added an assert to deal with this.

[SirVer (sirver)]

This was in r6604.

[Hans Joachim Desserud (hjd)]

Fwiw, they still show up (r6620), even after the assert has been added.

[SirVer (sirver)]

Could you update the html file? The current code trace should not be possible with the assert - but maybe I am mistaken.

[Hans Joachim Desserud (hjd)]

Here are the updated ones.

[SirVer (sirver)]

Thanks - those are false positives now. It does not seem to understand that only ever one flag is removed from the economy.

[Hans Joachim Desserud (hjd)]

I just ran a new scan on r6827 with llvm-3.4 and fwiw these issues are no longer listed. In my previous report from October last year they were, and that was run with llvm-3.3. Perhaps the new version of llvm silenced this false positive?

[SirVer (sirver)]

Released in build-18 rc1.