Move dict test matchers into testtools

[Ghe Rivero]

Reduce code duplication by pulling DictKeysMismatch, DictMismatch and DictMatches from glanceclient/tests/matchers.py into a library (e.g. testtools)

[Michael Davies (mrda)]

mrda@lawrence:~/src/openstack$ find . -name matchers.py
./nova/nova/tests/matchers.py
./keystone/keystone/tests/matchers.py
./ironic/ironic/tests/matchers.py
./trove/trove/tests/unittests/util/matchers.py

nova and trove share almost identical versions of these files, and ironic has content almost identical (includes Dict matches, but excludes XML matches). keystone has a very cut-down version.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/67897

[Doug Hellmann (doug-hellmann)]

Should these classes go directly to testtools instead of an oslo library? https://launchpad.net/testtools

[Dmitry Tantsur (divius)]

Hi! Any updates on this issue? Ghe, are you working on it? If not, could you please unassign yourself?

[Dmitry Tantsur (divius)]

Hi! As there was no new activity on this bug for a while, I'm unassigning it. Feel free to assign yourself, if you're still working on this bug.

[Dmitry Tantsur (divius)]

It's also not clear to me, whether the change actually got to Oslo - review mentioned here is abandoned

[Ben Nemec (bnemec)]

It doesn't look like this ever merged. It probably belongs in testtools, unless they won't take it for some reason.

[Doug Hellmann (doug-hellmann)]

The change was submitted to oslotest in https://review.openstack.org/#/c/74861/ and in that review I said:

I discussed this change with lifeless and he indicated that he would be very happy to have something like this (without committing to accepting this exact patch after only a quick review). Please submit a pull request to testtools (https://github.com/testing-cabal/testtools) and when it's committed we can bump the version of testtools OpenStack uses.

[Viktor Serhieiev (vsergeyev)]

@Doug,

pulling changes to testtools can take a lot of time (for example, we tried to add thee assertRaisesRegexp() method in February), so IMO, we can put them to the oslotest, and then remove, when we'll get this matchers in testtools

[Robert Collins (lifeless)]

@Victor we've no waiting-on-review pull requests open in testtools. Please give me a link to your pull request so I can see how the ball has been dropped. We generally have a couple day turnaround on testtools changes that are in good shape.

[Viktor Serhieiev (vsergeyev)]

@Robert,

please see pull request to testtools , which was sent on 3 Feb - [1]. For a some reasons, it was ignored during 6 months.

[1] https://github.com/testing-cabal/testtools/pull/75

[Robert Collins (lifeless)]

Can you rebase it please as I asked? YEs, sorry about the long delay there.

[Davanum Srinivas (DIMS) (dims-v)]

This need not be tracked by Nova.

[Robert Collins (lifeless)]

Still pending the patch being rebased for testtools.

[David Stanek (dstanek)]

Keystone no longer maintains those matchers so there isn't anything to fix anymore. The keystone/test/matcher.py module was removed in https://review.openstack.org/#/c/154242/

[Jonathan Lange (jml)]

https://github.com/testing-cabal/testtools/pull/185 has a rebased version of the assertRaisesRegexp patch, with tweaks.

[Jonathan Lange (jml)]

I've merged https://github.com/testing-cabal/testtools/pull/185. Marking this Fix Committed for testtools.

[Anup (anup-d-navare)]

This was fixed in Ironic:

commit 9670d2bd26a6228f6150f4698b2c55b4348af395
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Sep 16 22:58:04 2015 +0300

    Remove DictMatches custom matcher from unit tests

    On Py27 assertDictEqual handles nested dictionaries just fine.

    Change-Id: I0695a1249a3c4153ba4cc49405640a3e09a2af04
    Closes-Bug: #1496552