fix compilation warnings
Bug #1199533 reported by
Mario Guerriero
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Cable |
Fix Released
|
Medium
|
Julien Spautz | ||
Bug Description
Cable compilation shows about 70 Vala warnings. You should fix them or debugging code is too difficult e.g. when you have a compilation error it's hard to find it in the terminal output.
Related branches
lp:~julien-spautz/cable/model-view
- Eduard Gotwig (community): Needs Fixing
-
Diff: 8665 lines (+4717/-2866)50 files modifiedCMakeLists.txt (+40/-13)
README.rst (+121/-0)
data/org.pantheon.cable.gschema.xml (+0/-5)
po/cable.pot (+138/-143)
po/fr.po (+173/-142)
src/Cable.vala (+63/-26)
src/Controller/Channel.vala (+170/-0)
src/Controller/Server.vala (+65/-0)
src/Controller/Window.vala (+163/-0)
src/Dialogs/JoinChannel.vala (+12/-11)
src/Dialogs/ManageIdentity.vala (+46/-19)
src/Dialogs/ManageNetwork.vala (+18/-11)
src/Dialogs/Preferences.vala (+23/-30)
src/Irc/Channel.vala (+322/-0)
src/Irc/Client.vala (+59/-0)
src/Irc/Irc.vala (+43/-0)
src/Irc/Maki.vala (+278/-0)
src/Irc/Server.vala (+731/-0)
src/Services/Client.vala (+0/-278)
src/Services/Identity.vala (+0/-124)
src/Services/Launcher.vala (+66/-0)
src/Services/Network.vala (+0/-104)
src/Services/Notification.vala (+48/-0)
src/Services/Settings.vala (+0/-143)
src/Services/Unity.vala (+0/-64)
src/Settings/Preferences.vala (+39/-0)
src/Settings/Settings.vala (+33/-0)
src/Tests/Tests.vala (+13/-0)
src/Tests/Utils.vala (+101/-0)
src/Utils.vala (+0/-69)
src/Utils/AutoScrolled.vala (+44/-0)
src/Utils/EmbeddedAlert.vala (+424/-0)
src/Utils/Identity.vala (+201/-0)
src/Utils/Network.vala (+146/-0)
src/Utils/Utils.vala (+65/-0)
src/View/Channel.vala (+38/-0)
src/View/Server.vala (+69/-0)
src/View/Window.vala (+100/-0)
src/Widgets/Channel.vala (+82/-73)
src/Widgets/ChatDisplay.vala (+125/-10)
src/Widgets/Room.vala (+232/-283)
src/Widgets/Server.vala (+64/-338)
src/Widgets/ServerList.vala (+0/-104)
src/Widgets/TopicBar.vala (+72/-0)
src/Widgets/User.vala (+4/-84)
src/Widgets/Welcome.vala (+23/-22)
src/Widgets/Window.vala (+263/-0)
src/Window.vala (+0/-317)
vapi/libwnck-3.0.deps (+0/-7)
vapi/libwnck-3.0.vapi (+0/-446)
| Changed in cable: | |
| status: | New → Confirmed |
Revision history for this message
| Julien Spautz (julien-spautz) wrote | #1 |
Revision history for this message
| Julien Spautz (julien-spautz) wrote | #2 |
| Changed in cable: | |
| importance: | Undecided → Medium |
| Changed in cable: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Julien Spautz (julien-spautz) |
| Changed in cable: | |
| status: | In Progress → Fix Committed |
| Changed in cable: | |
| status: | Fix Committed → Fix Released |
| Changed in cable: | |
| milestone: | none → 0.1 |
To post a comment you must log in.
For those who a wondering where they come from, most of them complain about cable not catching IOErrors from maki's DBus interface.
There are also a lot of unused functions (again from maki's DBus interface).