export slices as HTML+CSS fails

[Ben Cottrell]

This bug was encountered from the following menus:
Extensions->Web->Slicer->Export layout pieces and HTML+CSS code...

When the extension runs, it returns the following message:

Traceback (most recent call last):
 File "webslicer_export.py", line 437, in <module>
e.affect()
File "C:\Program Files (x86)\Inkscape\share\extensions\inkex.py", line 215, in affect
self.effect()
File "webslicer_export.py", line 119, in effect
error = self.validate_inputs()
File "webslicer_export.py", line 75, in validate_inputs
self.unique_html_id( self.get_slicer_layer() )
File "webslicer_export.py", line 96, in unique_html_id
for child in el.getchildren():
AttributeError: 'NoneType' object has no attribute 'getchildren'

[su_v (suv-lp)]

Reproduced with Inkscape 0.48.4 and 0.48+devel r12419 on OS X 10.7.5 if trying to export without having defined any slicer rectangles in the current document (or more precisely: reproduced if the layer 'Web Slicer' is missing in the current document - export fails silently if the layer is present but empty).

Catching the error and returning a message explaining to the user to first create at least one slicer rectangle before applying 'Web > Slicer > Export layout pieces and HTML+CSS code' would be more user-friendly.

Basic description of the features of the extension:
<http://tavmjong.free.fr/INKSCAPE/MANUAL/html/Extensions-Web.html#Extensions-Web-Slicer>

[su_v (suv-lp)]

Proposed fix: return error message instead of failing with AttributeError if the user attempts to export a drawing which has not been set up for export yet.

[jazzynico (jazzynico)]

Patch tested successfully on Windows XP, Inkscape trunk rev. 14206.

[su_v (suv-lp)]

Patch committed to trunk in rev 14216.

[su_v (suv-lp)]

On 2015-06-22 17:04 (+0200), jazzynico wrote:
> ** Tags added: backport-proposed

The diff has a new string marked for translation - backport to 0.91.x nevertheless?

[jazzynico (jazzynico)]

> The diff has a new string marked for translation - backport to 0.91.x nevertheless?

The new message doesn't affect the main UI (tools, menus...) and is far more informative than the python error message. Thus I'd say yes, it can be backported to 0.91.x.

[su_v (suv-lp)]

Patch committed to 0.91.x in rev 13775.