Current code fails to meet our formatting style

Bug #1198640 reported by Rafał Cieślak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Millennium Duel
Fix Released
High
Przemysław Wawrzyniak

Bug Description

Because the code that is currently in the trunk was developed before we decided on our code formatting rules, it does not meet them. The problems include:

1. Wrong class names, missing the leading 'C'. (Also, the file names needs to be corrected too).
2. Lack of any comments and docstrings in header files.
3. Inconsistent naming of ClassMethods and class_fields.

The sooner we fix these, the less renaming will have to be done, and further code may be kept under the desired style.

Changed in millenniumduel:
assignee: nobody → Przemysław Wawrzyniak (przem-wawrzyniak)
status: Triaged → Confirmed
Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote : Re: [Bug 1198640] Re: Current code fails to meet our formatting style

Hint: status Confirmed oznacza "więcej niż jedna osoba twierdzą że ten bug
istnieje". Triaged to "istnienie buga potwierdzone jest przez kogoś, kto
zna się w tym temacie". Natomiast jest jeszcze stosowny w tej sytuacji
InProgress, czyli "osoba przypisana do tego buga wzięła się już do roboty".

Wydaje mi się, że niekoniecznie chciałeś przestawić status z Triaged na
Confirmed :-)

Changed in millenniumduel:
status: Confirmed → Triaged
Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

Bug #1204513 (Widget classes should use a 'W' prefix.) is related and might be fixed simultaneously.

https://bugs.launchpad.net/millenniumduel/+bug/1204513

Changed in millenniumduel:
status: Triaged → In Progress
Changed in millenniumduel:
status: In Progress → Fix Committed
Changed in millenniumduel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.