Cable

Up and down arrows should navigate in the messages history

Bug #1198635 reported by Mario Guerriero
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Cable
Fix Released
Wishlist
Daniele "OpenNingia" Simonetti
Cable 0.1

Bug Description

Pressing Up and Down arrows users should be able to navigate into sent messages history like it happens for the terminal.

Related branches

lp:~oppifjellet/cable/message-history
Eduard Gotwig: Pending requested
Diff: 405 lines (+258/-10)
7 files modified
CMakeLists.txt (+22/-1)
src/Utils/RRStringList.vala (+77/-0)
src/Widgets/Room.vala (+31/-9)
tests/TestCase.vala (+58/-0)
tests/TestExample.vala (+22/-0)
tests/TestMain.vala (+7/-0)
tests/TestMessageHistory.vala (+41/-0)
Julien Spautz (julien-spautz)
Changed in cable:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Daniele "OpenNingia" Simonetti (oppifjellet) wrote :

I implemented this behavior in this branch
lp:~oppifjellet/cable/message-history

Julien Spautz (julien-spautz)
Changed in cable:
assignee: nobody → Daniele "OpenNingia" Simonetti (oppifjellet)
status: Triaged → Fix Released
milestone: none → 0.1
Revision history for this message
Daniele "OpenNingia" Simonetti (oppifjellet) wrote :

@julien: in your refactoring you removed the size contraint of the history buffer. Aren't you concerned about memory usage?

Revision history for this message
Julien Spautz (julien-spautz) wrote :

Not really, no. A string takes up less than a KB, you'd need more than a thousand messages to fill only a MB of RAM, which is almost nothing nowadays. Also, it wouldn't be hard to add back, if necessary.

I just don't think we need it.

Revision history for this message
Julien Spautz (julien-spautz) wrote :

Also there are better places to optimize memory usage, eg. bug #1210334

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.