Ubuntu
fwts package

fwts: efi_runtime build warning on efi_enabled

Bug #1198150 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Firmware Test Suite
Fix Released
High
Unassigned
Firmware Test Suite 13.08.00
fwts (Ubuntu)
Fix Released
High
Colin Ian King

Bug Description

We're getting efi_runtime build warnings with recent kernels:

make -C /lib/modules/`uname -r`/build M=`pwd` modules
make[1]: Entering directory `/usr/src/linux-headers-3.8.0-25-generic'
  CC [M] /home/king/tmp/fwts/efi_runtime/efi_runtime.o
/home/king/tmp/fwts/efi_runtime/efi_runtime.c: In function ‘efi_runtime_init’:
/home/king/tmp/fwts/efi_runtime/efi_runtime.c:364:6: warning: the address of ‘efi_enabled’ will always evaluate as ‘true’ [-Waddress]

This occurs because of kernel commit 83e681897 which turned efi_enabled from an integer into a function, hence efi_enabled will always now evaluate as true.

Colin Ian King (colin-king)
Changed in fwts (Ubuntu):
status: New → In Progress
assignee: nobody → Colin King (colin-king)
importance: Undecided → High
Revision history for this message
Colin Ian King (colin-king) wrote :

Patch sent to mailing list https://lists.ubuntu.com/archives/fwts-devel/2013-July/003517.html

Revision history for this message
Colin Ian King (colin-king) wrote :

Fix committed 0fe2f0b60084854a4c1e3ad23dbb36edf6177253

Changed in fwts (Ubuntu):
status: In Progress → Fix Committed
Keng-Yu Lin (lexical)
Changed in fwts:
status: New → Fix Committed
milestone: none → 13.08.00
importance: Undecided → High
Colin Ian King (colin-king)
Changed in fwts (Ubuntu):
status: Fix Committed → Fix Released
Changed in fwts:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.