Midori Web Browser

No icon on error page Reload button

Bug #1197950 reported by Cris Dywan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Critical
Cris Dywan
Midori Web Browser 0.5.4 "Depanelitis Spedalia"

Bug Description

The new error page design introduced a regression by removing the icon on the button (if enabled). Unfortunately it was merged before I remembered to mention it.

Tags: regression

Related branches

lp:~kalikiana/midori/reloadicon2
Paweł Forysiuk: Approve
Diff: 11 lines (+1/-0)
1 file modified
data/error.html (+1/-0)
Cris Dywan (kalikiana)
Changed in midori:
assignee: nobody → Alexander Wilms (alexander-wilms)
Revision history for this message
982c80311320c1b (alexander-wilms) wrote :

I actually removed it on purpose since IMHO it looked cleaner. Maybe I can re-add i tomorrow

Revision history for this message
Cris Dywan (kalikiana) wrote :

All native buttons with an obvious symbolism do use icons. Help/ Close in the preferences, Add/ Cancel in the bookmark dialog to mention some. It's up to the desktop environment to enable or disable; if you think less icons is "cleaner" you disable globally.

Revision history for this message
982c80311320c1b (alexander-wilms) wrote : Re: [Bug 1197950] Re: No icon on error page Reload button

Is it possible to detect whether icons on buttons are enabled or not and
make the visibility of the icon depend on it?

Revision history for this message
gue5t gue5t (gue5t) wrote :

Yes; we should probably do that. See <https://developer.gnome.org/gtk3/unstable/GtkSettings.html#GtkSettings--gtk-button-images>.

Revision history for this message
Cris Dywan (kalikiana) wrote :

Look at the diff breaking this and it already did exactly that ;-)

Cris Dywan (kalikiana)
Changed in midori:
assignee: Alexander Wilms (alexander-wilms) → Christian Dywan (kalikiana)
status: Confirmed → In Progress
Cody Garver (codygarver)
Changed in midori:
status: In Progress → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.