Email record detail does not check for email

[Pasi Kallinen]

*EG master

In OPAC there's an "Email" link that makes the system email the record details to the patron. Clicking on that link always shows "Your email has been queued for Delivery" - even when the patron has no email address set.

[Ben Shum (bshum)]

I might play with this one in the coming weeks.

[Dan Pearl (dpearl)]

I'm working on this.

[Dan Pearl (dpearl)]

Done. This will intercept the lack of email and give the user the opportunity to add one to their profile.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/email_1197636

[Jason Stephenson (jstephenson)]

I think the language should be less folksy and should use the third person for the first sentence. "Oops!" should also be removed.

Just my opinion.

[Thomas Berezansky (tsbere)]

In addition to Jason's comment, I think that you should insert the email address and link into the language strings via placeholders (who is to say that the email address or "here" link should be at the *end* in all languages?).

[Jason Stephenson (jstephenson)]

I just want to add that I tested the branch this morning and it works great.

[Jason Stephenson (jstephenson)]

I dropped the 2.8 and 2.9 series targets because we don't want branches with translated strings in bug fix point release branches. We only do translations at "major" release time, so backported strings changes can lead to someone on a translated Evergreen having non-translated strings show up unexpectedly.

This is not meant as a slight on Dan's efforts. Just that we need to be aware of translation issues.

[Dan Pearl (dpearl)]

Going to knock this one off, Jennifer? If you don't have time, I could do it.

Dan

[Kathy Lussier (klussier)]

Hi Dan,

Jennifer assigned herself because she is testing it for Bug Squashing Day. I think the changes Jason and Thomas requested will still need to be done before the code is merged.

Kathy

[Kathy Lussier (klussier)]

Also, if the changes are done before Jennifer gets a chance to test it, I should have time to load it on to a Sandbox in short order so that she can test the latest and greatest!

[Jennifer Pringle (jpringle-u)]

If a wording change happens I suggest "Your account does not currently have an email address set. Set your email address here."

[Jennifer Pringle (jpringle-u)]

This code works as described up to the point of the email being sent (the test server does not send email).

I have tested this code and consent to signing off on it with my email address, <email address hidden>, and name, Jennifer Pringle.

[Dan Pearl (dpearl)]

I have addressed the outstanding issues and retested the code. Thank you for your comments.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/email_1197636_A

[Galen Charlton (gmc)]

Tested; my signoff branch is user/gmcharlt/lp1197636_signoff. I've also applied the rm-to-write-notes tag, as a one-liner will suffice for the release notes for this.

[Ben Shum (bshum)]

Pushed to master.