Confusing playlists save dialog (filetype combobox doesn't set type)

[xorik]

Steps:
1. Select any playlist/crate
2. Click "Export playlist"
3. Select any file type, e.g. "Text CSV"
4. Save file

Expected result: CSV file
Actual result: M3U file

Same thing with others filetypes in combobox.

Gentoo x86_64, mixxx from trunk

[Daniel Schürmann (daschuer)]

Is it a bug or a feature? ;-) Ok, you have reported it, so it is a bug.

The combo box is part of the system file dialog. And it sets only a filter for the files in the view.
The type of play-list is selected by the file extension only.

To fix this issue, we have to write our own file save dialog, that may will feel foreign on some systems, or we can pop up a type selection box before showing the native file dialog.

[xorik (xor29a)]

I'm try to write to export into traktor's NML playlist, and was totified: the combobox isn't working :)
Usualy in other software this combobox selects file type to export (e.g. OpenOffice or Audacity).

I think Qt must have something, to handle this combobox?

[xorik (xor29a)]

*notified

[Daniel Schürmann (daschuer)]

I would be glad if you could find a smart fix.

[RJ Skerry-Ryan (rryan)]

Dennis has a useful comment in Bug #1402841.

I agree that it's expected behavior that if you select a specific type from the drop-down then type a filename with no extension then we should append the one you selected to it.

"""
Under Ubuntu 14.04 Playlist Export function only exports m3u files.

This failure is due to QFileDialog::getSaveFileName only returns filename without extension under Linux.

This bug has been reported here: https://bugreports.qt-project.org/browse/QTBUG-27186

You can hack around this issue by defining a QString selfilter = tr("M3U Playlist (*.m3u)") which returns the appropiate filter (like Readable Text (*.txt)) after dialog is closed.

Afterwards extract the extension out of the string and append it to QString file_location in baseplaylistfeature.cpp in line 393.
Ugly hack tho :\
"""

[Daniel Schürmann (daschuer)]

https://github.com/mixxxdj/mixxx/pull/430

[Dennis Rohner (midzer)]

Can be set to "Fix commited" as PR is merged to master

[Sascha (lxndr71)]

I have the same problem again with build 2.3 r7506 on Linux Mint 19.1

No matter what I choose, it only exports to m3u

[Sascha (lxndr71)]

I have to explicitly name the file .txt or .pls in the Filename field and set the filetype accordingly, else I only get m3u

[Daniel Schürmann (daschuer)]

Since this one is already released.
Can you file a new bug?
This way we can track the issue without messing around with the 2.0 changes.

[Sascha (lxndr71)]

o.k.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7090