Most tests are silently disabled if libumockdev-dev is missing
Bug #1196987 reported by
Alan Griffiths
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Alan Griffiths |
Bug Description
Since -r 798, if umockdev is missing cmake "succeeds" but no tests are built by the resulting makefile.
If we're going to allow disabling test generation there should be an explicit option to request it.
Related branches
lp:~alan-griffiths/mir/fix-1196987
- PS Jenkins bot (community): Approve (continuous-integration)
- Thomas Voß (community): Approve
- Kevin DuBois (community): Approve
-
Diff: 102 lines (+14/-20)5 files modifiedCMakeLists.txt (+5/-10)
cross-compile-chroot.sh (+4/-0)
debian/control (+1/-0)
tests/CMakeLists.txt (+3/-10)
tools/setup-partial-armhf-chroot.sh (+1/-0)
Changed in mir: | |
assignee: | Daniel van Vugt (vanvugt) → nobody |
Changed in mir: | |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
Changed in mir: | |
status: | Confirmed → In Progress |
Changed in mir: | |
milestone: | none → 0.0.6 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I don't think we need an explicit option to request tests disabled. Instead we just need to improve the CMakeLists to be smarter, and only disable those tests that need to be disabled.