wsrep_sst_mysqldump fails with unbound variable warning

[Alex Yurchenko]

/root/shm/mysql-5.5.31-3883,3143M/mysql//bin/wsrep_sst_common: line 89: WSREP_SST_OPT_DATA: unbound variable

This is a regression introduced by Percona (and mindlessly merged in by Codership) related to https://bugs.launchpad.net/codership-mysql/+bug/1193215

However it is not clear how to proceed from here, as progress indicator is a long awaited feature and mysqldump SST is not really dead yet.

WORKAROUNDS:
a) use another SST method
b) comment out line 89 if using mysqldump

[Raghavendra D Prabhu (raghavendra-prabhu)]

Thanks, I will fix it. The sst progress was added only for rsync and xtrabackup SST methods.

Is WSREP_SST_OPT_DATA not set for mysqldump SST method?

[Raghavendra D Prabhu (raghavendra-prabhu)]

Fixed with

[ -n $WSREP_SST_OPT_DATA ] && SST_PROGRESS_FILE="$WSREP_SST_OPT_DATA/sst_in_progress"

However, progress indicator in lp:1193215 is not same as
lp:1193215, former is only applicable for blocking init scripts
till SST is complete, latter is meant to indicate SST progress.

[Alex Yurchenko (ayurchen)]

Well, mysqldump is not totally dead yet, and probably would benefit from progress indication as well. But in order to make it rsync/xtrabackup compatible we'll need to pass datadir to it. That would require a small change in wsrep_sst.cc.

[Raghavendra D Prabhu (raghavendra-prabhu)]

Ack, I intended to add this progress file for mysqldump too but it was a bit different there, hence didn't add. I will add it in a separate issue.

[Raghavendra D Prabhu (raghavendra-prabhu)]

"However, progress indicator in lp:1193215 is not same as
lp:1193215, former is only applicable for blocking init scripts
till SST is complete, latter is meant to indicate SST progress."

should be

"However, progress indicator in lp:1099428 is not same as
lp:1193215, former is only applicable for blocking init scripts
till SST is complete, latter is meant to indicate SST progress."

[Seppo Jaakola (seppo-jaakola)]

Merged the PXC fix into codership-mysql, in revision: http://bazaar.launchpad.net/~codership/codership-mysql/5.5-23/revision/3895

[Marc Castrovinci (marc-castrovinci)]

I'm seeing the same problem with wsrep_sst_xtrabackup

/usr/bin/wsrep_sst_xtrabackup
/usr/bin/wsrep_sst_common: line 89: WSREP_SST_OPT_DATA: unbound variable

[Marc Castrovinci (marc-castrovinci)]

I retract my previous comment. I only now realized that the problem is was in wsrep_sst_common. Obviously the fix would apply to the other scripts that depend on it.

[Raghavendra D Prabhu (raghavendra-prabhu)]

@Marc,

You shouldn't have received this error while using wsrep_sst_xtrabackup since datadir is passed to the script. If you did, then it is either a bug elsewhere or in option handling. (or with handling of innodb_data_home_dir etc.)

[Alex Yurchenko (ayurchen)]

Reopening, since I'm getting this

/run/shm/galera1/mysql//bin/wsrep_sst_mysqldump: 89: /run/shm/galera1/mysql//bin/wsrep_sst_common: WSREP_SST_OPT_DATA: parameter not set

- at least with dash. Also, SST_PROGRESS_FILE cleanup is buggy this way

[Alex Yurchenko (ayurchen)]

Pushed fix in http://bazaar.launchpad.net/~codership/codership-mysql/5.5-23/revision/3903

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXC-1387