Fix disabled acceptance tests for the decor plugin and run them by default
Bug #1195522 reported by
Sam Spilsbury
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Compiz |
Fix Released
|
Medium
|
Sam Spilsbury | ||
compiz (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Now that we have acceptance tests for the decor plugin defining what the behavior should be, the next step is to fix the failing tests and get them running by default. Currently 19 or so tests fail.
Related branches
lp:~compiz-team/compiz/compiz.fix_1195522
- PS Jenkins bot (community): Approve (continuous-integration)
- MC Return: Approve
- Brandon Schaefer (community): Approve
- Andrea Azzarone: Pending requested
- Compiz Maintainers: Pending requested
-
Diff: 2357 lines (+758/-645)24 files modified.bzrignore (+1/-0)
plugins/decor/src/decor.cpp (+47/-132)
plugins/decor/src/decor.h (+5/-1)
plugins/decor/tests/acceptance/xorg-gtest/CMakeLists.txt (+1/-1)
plugins/decor/tests/acceptance/xorg-gtest/compiz_decor_acceptance_tests.cpp (+74/-212)
plugins/move/src/move.cpp (+19/-9)
plugins/opengl/src/paint.cpp (+1/-1)
plugins/place/src/constrain-to-workarea/include/constrain-to-workarea.h (+3/-6)
plugins/place/src/constrain-to-workarea/src/constrain-to-workarea.cpp (+25/-49)
plugins/place/src/constrain-to-workarea/tests/constrain-to-workarea/src/test-place-constrain-to-workarea.cpp (+4/-57)
plugins/place/src/place.cpp (+15/-16)
src/event.cpp (+7/-2)
src/plugin.cpp (+15/-2)
src/plugin/tests/test-plugin.cpp (+40/-0)
src/window.cpp (+71/-58)
src/window/extents/src/windowextents.cpp (+10/-0)
tests/manual/README.txt (+9/-0)
tests/manual/plugins/decor.txt (+40/-0)
tests/system/xorg-gtest/tests/compiz_xorg_gtest_configure_window.cpp (+91/-73)
tests/xorg-gtest/CMakeLists.txt (+2/-1)
tests/xorg-gtest/include/compiz-xorg-gtest.h (+79/-3)
tests/xorg-gtest/plugins/testhelper/src/testhelper.cpp (+5/-8)
tests/xorg-gtest/src/compiz-xorg-gtest-config.h.in (+2/-1)
tests/xorg-gtest/src/compiz-xorg-gtest.cpp (+192/-13)
Changed in compiz: | |
milestone: | none → 0.9.10.0 |
To post a comment you must log in.
+1 for fixing this.
For me this bug even has "High" importance though... ;) Emerald+ Unity working 100% again...)
(because decor currently messes up Emerald quite a bit and I am excited to see Compiz+