Evergreen

Some data URIs don't define character set

Bug #1195334 reported by Pasi Kallinen on 2013-06-27

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Evergreen	Fix Released	Undecided	Unassigned	Evergreen 2.5.0-m2

Bug Description

*EG master

Some iframes and new windows use data URIs for the contents, but do not define the charset. The charset defaults to US-ASCII, and will cause problems with UTF-8 text.

Fix at user/paxed/data-uri-charsets - it also changes relevant escape() calls to encodeURIComponent() ones (so the UTF-8 character stay intact), and fixes the print template macro help window size.

Tags:

Pasi Kallinen (paxed) on 2013-06-28

tags:

added: pullrequest

Revision history for this message

Pasi Kallinen (paxed) wrote on 2013-07-01:

Before and after applying the fix Edit (99.0 KiB, image/png)

Pasi Kallinen (paxed) on 2013-07-02

Changed in evergreen:
milestone:	none → 2.5.0-m2

Jason Etheridge (phasefx) on 2013-07-12

Changed in evergreen:
assignee:	nobody → Jason Etheridge (phasefx)

Revision history for this message

Jason Etheridge (phasefx) wrote on 2013-07-12:

Works for me, committed to master. There was one change not dealing with UTF-8, with the Macros button in the receipt template editor, and that was removing some inline CSS and replacing it with a change to how we invoke window.open, which is fine with me.

Thanks Pasi!