Cannot create a volume snapshot from Dashboard

Bug #1194506 reported by Rohit Karajgi
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Julie Pichon

Bug Description

Attempt to create a snapshot from a volume booted created from image fails:

Steps:
1. Create a volume from an image
2. Create a snapshot of the volume

Result:

in horzon log:
[Tue Jun 25 13:32:09 2013] [error] File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py", line 138, in find_template
[Tue Jun 25 13:32:09 2013] [error] raise TemplateDoesNotExist(name)
[Tue Jun 25 13:32:09 2013] [error] TemplateDoesNotExist: project/volumes/_quota.html

Full stacktrace:
http://paste.openstack.org/show/39195/

Julie Pichon (jpichon)
Changed in horizon:
status: New → Incomplete
status: Incomplete → Confirmed
Revision history for this message
Julie Pichon (jpichon) wrote :

A few things here:

- openstack_dashboard/dashboards/project/volumes/templates/volumes/_create_snapshot.html still references _quotas.html instead of _limits.html
- the CreateSnapshotView still references tenant_quote_usages instead of absolute_limits
- however it doesn't look like cinder's absolute limits return the current usage, only the max allowed? We may need to stick to quotas for now, and revert the _quotas template to what it used to be (currently _limits.html references variable such as usages.gigabytesUsed that do not exist, as far as I can tell)

Nuno Santos (nunosantos)
Changed in horizon:
assignee: nobody → Nuno Santos (nunosantos)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/36528

Changed in horizon:
status: Confirmed → In Progress
Julie Pichon (jpichon)
Changed in horizon:
importance: Undecided → High
Revision history for this message
Rohan (kanaderohan) wrote :

Hi Nuno Santos, will you be pushing a corrected fix for this bug? The snapshot limit/quota is not used in your current patch, I have fixed this issue in my environment, I can share the fixed patch with you, Or if you are not working on this bug then i can push a new review to fix this issue.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/40588

Changed in horizon:
assignee: Nuno Santos (nunosantos) → Rohan (kanaderohan)
Rohit Karajgi (rohitk)
Changed in horizon:
assignee: Rohan (kanaderohan) → nobody
Changed in horizon:
assignee: nobody → Rohan (kanaderohan)
Revision history for this message
Jeff Applewhite (ajeffrey) wrote :

I am hitting a similar issue using the Netapp driver for nfs and iscsi except all snapshots from the horizon gui fail whether they were created from an image or not.

Julie Pichon (jpichon)
Changed in horizon:
milestone: none → havana-rc1
Revision history for this message
Julie Pichon (jpichon) wrote :

I will propose a patch that fixes the template and quota/limit issues, and attempts to address the comments made on the previous reviews notably about centralised quotas in the one file. The centralisation was somewhat lost during the move from quotas to limits and the result is a bit confusing -- I filed bug 1227169 to address a future refactoring separately (probably for Icehouse).

Changed in horizon:
assignee: Rohan (kanaderohan) → Julie Pichon (jpichon)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/47203

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/47203
Committed: http://github.com/openstack/horizon/commit/2ed62bb2e5c50e6abf87115539b38c8f81dabf0f
Submitter: Jenkins
Branch: master

commit 2ed62bb2e5c50e6abf87115539b38c8f81dabf0f
Author: Julie Pichon <email address hidden>
Date: Wed Sep 18 17:05:04 2013 +0100

    Fix volume snapshot creation

    The referenced template was wrong, and the quota usages information
    had not been switched to using limits.

    Thanks to Nuno Santos and Rohan Kanade for the initial versions of
    this patch.

    Change-Id: I97f578b84cd1cd4babab2580c60f0132026e3c93
    Closes-Bug: #1194506

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.