Pre-cat "dummy" title/author displayed on non-pre-cat in staff client

[Jeff Godin]

When dealing with a pre-cataloged item, we want the "dummy" title and author displayed. Once a pre-cataloged item is turned into a "real" copy, we should no longer display the dummy_title and dummy_author fields.

Currently, in the staff client when checking out a FORMERLY pre-cataloged item to a patron, the dummy_title and dummy_author fields are displayed in place of the title and author from the mvr.

Other displays in the staff client appear fine.

Short of setting dummy_title and dummy_author to null for records where call_number <> -1, we can fix this by checking the copy's call number ID before overriding the mvr title/author in Open-ILS/xul/staff_client/server/circ/checkout.js

A trigger for clearing dummy_title and dummy_author whenever a copy moved from call_number -1 to a different call_number might also be considered, but I'm not convinced that it's needed.

[Ben Shum (bshum)]

I like checking for the -1 call number in checkout.js and leaving the dummy data in the copy. Might be handy in case one were tracking down in the future whether the right pre-cat made it to the right record?

[Steve Callender (stevecallender)]

I created a patch based on Bens comments. I've added in a check to make sure the call number is still -1 before pulling the summy info from the copy.

Patch is here,

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=85b990a1d950777ac167ef364027f8d479117fe6

Steve

[Ben Shum (bshum)]

Picked to master and backported to rel_2_5 and rel_2_4. Thanks Steve!